marcincichocki / summonersconfig Goto Github PK

End user should be notified if account's runes and masteries were successfully imported to application.

During bootstraping screen is blank. User might be confused what is going on. Name of application and loading spinner should be displayed on the screen until app is loaded.

runeService should not have function to modify view. Its purpose is to provide data and operation on these, not to change the view. .isPercentage() should be moved to new pipe and used from there.

Styles inside angular templates should be prefixed to display properly on older browsers.

Data loaded on init(runes and masteries static data) should have own interfaces instead of being type any. Here is preview for runeService

// staticData.ts
export interface STATIC_DATA_UNITS {
  [key: string]: string;
}

export interface STATIC_DATA_RUNES {
  [key: string]: {
    id: number;
    name: string;
    description: string;
    tier: number;
    image: string;
    primary: string;
    type: string;
    available: boolean;
    ip: number;
    tags: string[];
    stats: {
      [key: string]: number;
    };
  };
}

// runeService.ts
import {STATIC_DATA_UNITS, STATIC_DATA_RUNES} from './staticData';
// ...
class RuneService { 
  // Data is loaded async.
  public units: STATIC_DATA_UNITS = {};
  public runes: STATIC_DATA_RUNES = {};
  // ...

  someFunction(id, unitId) {
    // Intelisense works!
    this.runes[id].stats[unitId].toFixed(2);
  }
}

Application's assets should be updated to latest patch.

Tooltip does not change its position if both edges of the screen are exceeded.

In angular2.0.0-alpha.50 and onwards res.json() return any so array notation shouldn't be used anymore.

Allow user to import runes and masteries for given server and summoner name.

Things to be done:

• Import component(home should be fine, now it is empty).
• Styles(form should be big, easy to notice, most probably centerd).
• Server handle request to riot api and return data.
• Client populate pages with data received(services should handle that).

Search pipe throws an error when special character is passed. It happen because whole filtering thing is builded with regexp. This should be fixed with escaping special characters(like * or +) or using different method(like includes or indexOf).