marcelgarus / repository Goto Github PK

If I create an InMemoryStorage repository and then I call fetchAll(), fetchAllIds() of fetchAllItems() as first method call, the stream returned is empty and if i try to get the first element i get a pending future that never complete until I call update() or remove() on the repositiory. This is because initially the _allEntriesController BehaviourSubject is empty and only if I call update() or remove() on the repository the BehaviourSubject is not empty.
The solution is simple, put an initial empty map on _allEntriesController.

The cache repository currently doesn't have allow intuitive use cases because a lot of information is lost if it just provides Streams of Items. I'll therefore update the API so that it's rather a repository of CacheItem<Item>, where CacheItem contains the origin (whether the information is from the source or the cache) as well as either data or an error.

I was intrigued by the prospect of a repo library. However, looking through pub pages and the Github repo I found the lack of a few examples, and documentation to be very limiting. It's not that developers can't spend time reading and grokking your code, but who has time to dig that deep when trying to decide if a library is worth using. I suspect your library gets passed over because of this lack of information. Also, if it doesn't already, the library should be able to handle gathering data from two sources easily. Anything above your library shouldn't need to know if the data came from a cache or an API call. The repo should handle this. I think your library would be much more popular if you documented it with good documentation and provided multiple code samples so devs can see how to use it and how it would be helpful without taking the time to dig into the details of how it works. I hope this helps and gives you a little motivation to continue developing this and other Flutter libraries.