Coder Social home page Coder Social logo

Comments (2)

ASLeonard avatar ASLeonard commented on September 17, 2024 1

Great, thanks Brian.

I commented out that line from AS_configure, and the threading now responds to the OMP variable without the need for the explicit -threads param. Merqury back to being super quick!

from merqury.

brianwalenz avatar brianwalenz commented on September 17, 2024

For such a simple bug, the phenotype is surprisingly complicated.

It's only affecting OMP_NUM_THREADS. Using any other environment variable (e.g., SLURM_JOB_CPUS_PER_NODE) to set the number of threads to use works as expected.

Meryl isn't affected because it queries the number of threads allowed before AS_configure() is called, while meryl-lookup calls AS_configure() first.

I think the correct fix is to remove omp_set_num_threads(1) from AS_configure(). This was added to disable OpenMP parallelization of std::sort, but we're now doing that through a different mechanism. For meryl/merqury removing this should be safe; it was canu that had problems here.

from merqury.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.