Comments (2)
Great, thanks Brian.
I commented out that line from AS_configure, and the threading now responds to the OMP variable without the need for the explicit -threads
param. Merqury back to being super quick!
from merqury.
For such a simple bug, the phenotype is surprisingly complicated.
It's only affecting OMP_NUM_THREADS. Using any other environment variable (e.g., SLURM_JOB_CPUS_PER_NODE) to set the number of threads to use works as expected.
Meryl isn't affected because it queries the number of threads allowed before AS_configure() is called, while meryl-lookup calls AS_configure() first.
I think the correct fix is to remove omp_set_num_threads(1)
from AS_configure(). This was added to disable OpenMP parallelization of std::sort, but we're now doing that through a different mechanism. For meryl/merqury removing this should be safe; it was canu that had problems here.
from merqury.
Related Issues (20)
- how can I get spectra-cn reads only plot HOT 8
- Error in zero_range(range) when plot spectra-asm HOT 1
- wig instead of tdf and haplotype phasing HOT 1
- Single diploid individual quality estimates and completeness HOT 4
- False duplications HOT 3
- First peak identified as read-only HOT 2
- Multiple reads datasets as meryl input HOT 1
- bining Hi-C reads HOT 1
- Merqury or Merfin? HOT 3
- ccs.bam, fasta assemblies and meryl dataset HOT 3
- How to get blob plots HOT 17
- QV i n some chr is +inf HOT 3
- Adjusting plots of spectra plots HOT 1
- K-mer comparison density plot HOT 2
- NG block HOT 2
- No resulting plots.. HOT 2
- Understanding what total represents in different output files HOT 3
- Rscript execution error HOT 2
- Can't interpret 'fastp/*.meryl': not a meryl command, option, or recognized input file.
- merqury.completeness.stats empty HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merqury.