Breaking changes in changeset Feb 11, 2024, 08:88 e41e3536fd58417dc84099c13038bf0bc8bbc69b ? about mapsui

[pauldendulk]

In main there are many breaking changes. We are still before the release of 5.0.0-beta.1 and when that is released we are going to tell people that there will be more breaking changes.

But perhaps you are pointing us to a bug we introduced. For this we need some more information. The editing samples have bugs they way they are now (differences in behavior between platforms) so it is hard to tell what the bug is. There need to be breaking changes in the widgets events to fix this. Still, the end result of v5 should that editing works properly. So, I'd be interested in more information.

[starnutoditopo]

I just reported it because I noticed the different behavior, but it definitely looks like you are aware of it. That's fine. If you want to have a look, I added you as a collaborator to my pet project https://github.com/starnutoditopo/WpfFly. I'd like to open-source it, if I manage to make it work (it contains some unit-tested facilities to calculate rhumb bearing and rhumb distance: feel free to grab them, if you think they may be useful for mapsui!).

…

On Mon, Feb 12, 2024 at 8:38 PM Paul den Dulk ***@***.***> wrote: In main there are many breaking changes. We are still before the release of 5.0.0-beta.1 and when that is released we are going to tell people that there will be more breaking changes. But perhaps you are pointing us to a bug we introduced. For this we need some more information. The editing samples have bugs they way they are now (differences in behavior between platforms) so it is hard to tell what the bug is. There need to be breaking changes in the widgets events to fix this. Still, the end result of v5 should that editing works properly. So, I'd be interested in more information. — Reply to this email directly, view it on GitHub <#2498 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAK3JPLMACXVREFECEQS3G3YTJVS5AVCNFSM6AAAAABDELW6YCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGQZDCMJSGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[pauldendulk]

Well I am making big changes and will also introduce some bugs too. Still more changes are coming. I will be happy to get more thorough testing in the next phase. I will let you know.

[pauldendulk]

Mapsui 5.0.0-beta.1 was released with a major update of touch and mouse handling. I would be happy with some testing. Here is a checklist with suggestions on how to test: https://mapsui.com/v5/documentation/touch-and-mouse-handling.html. Please create new issues for the things you find.

[starnutoditopo]

Mapsui 5.0.0-beta.1 was released with a major update of touch and mouse handling. I would be happy with some testing. [...]

I made some basic tests on MAUI and it looks fine. Great job!

I only have some concerns about the naming of the base class InputOnlyWidget: any derived class is supposed to add something and not to be an input-only widget. I'd rather prefer something like ProvidesInputFacilitiesWidget or AcceptingInputWidget, so that derived classes would not be "input-only" widgets, but widgets that provide some capabilities and also "provide input facilities" or "accept input".