In Map.DataChanged event, DataChangedEventArgs Layer name is empty. It should contains the Layer Name. about mapsui

[pauldendulk]

Thanks for reporting this. It looks like a bug.

[pauldendulk]

Had a look at this. We could make the layer Name a mandatory parameter of the OnDataChangedEventArgs constructor. This solves a lot of problems but a complication is that it is also used in some providers. So, perhaps in those cases the providers should return another type of event args (OnProviderDataChangedEventArgs?) and the layers should create their own OnDataChangedEventArgs when they handle those events.

[damusthe]

The workaround I used is the following :

/// <summary>
/// Map DataChanged event to generate IsBusy ViewModel for showing activity indicator
/// </summary>
/// <param name="sender"></param>
/// <param name="e"></param>
private void Map_DataChanged(object sender, Mapsui.Fetcher.DataChangedEventArgs e)
{
	if ((sender != null) && (sender is ILayer) && ((ILayer)sender).Name == "OpenStreetMap")
	{
		IsBusy = ((ILayer)sender).Busy;
	}
}

I'm using the sender ILayer.Name instead of the event args.

I don't know enough Mapsui architecture, but changing DataChangedEventArgs type on context would be a problem at use.

[pauldendulk]

I fixed this in main by making the layerName constructor argument mandatory for the DataChangeEventArgs and remove use of it in non-layers. These now use an event with minimal data.
#2685

I improved this in develop/4.1 without introducing breaking changes
#2684