mapsme / just_gtfs Goto Github PK

Not a biggie, but it'd make the API more useful IMHO, if we added a uint8_t bitmask for the CalendarItem telling us easily which days are valid. Currently it's "lots" of code to capture that downstream.

The header for shapes.txt is missing the shape_dist_traveled field, while the data actually writes it, resulting in a broken CSV.

Hi,
Based on:
https://gtfs.org/reference/static/#transferstxt

Indicates the type of connection for the specified (from_stop_id, to_stop_id) pair. Valid options are:

0 or empty - Recommended transfer point between routes.
1 - Timed transfer point between two routes. The departing vehicle is expected to wait for the arriving one and leave sufficient time for a rider to transfer between routes.
2 - Transfer requires a minimum amount of time between arrival and departure to ensure a connection. The time required to transfer is specified by min_transfer_time.
3 - Transfers are not possible between routes at the location.

Therefore, the 'transfer_type' values can be empty, so:

inline Result Feed::add_transfer(const ParsedCsvRow & row)
{
  Transfer transfer;
  try
  {
    // Required fields:
    transfer.from_stop_id = row.at("from_stop_id");
    transfer.to_stop_id = row.at("to_stop_id");
    set_field(transfer.transfer_type, row, "transfer_type", false);

    // Optional:
    set_field(transfer.min_transfer_time, row, "min_transfer_time");
  }

should be changed to:
set_field(transfer.transfer_type, row, "transfer_type");

Hi, I was working on a project which is not c++17 compatible, so I made a patch to made your library compatible with c++14 using boost,
Can you look into it?
Can you accept it as a separate branch for other people to use

Stop uses StopLocationType::GenericNode as default value. However, the GTFS Reference states that its default value should be StopLocationType::StopOrPlatform

empty transfers field in fare_attributes is allowed, and that means Unlimited transfers are permitted

please check the specification (https://gtfs.org/reference/static#fare_attributestxt)

do you have some special technique to handle such conditions or you just treat this field as optional,