Large screen: unwanted pan-jump as pan action finishes (3d terrain) about maplibre-gl-js

[olsen232]

Okay I've found a simple culprit - once this expression is not returning a consistent result, the math ends up wrong:
map.painter.width / devicePixelRatio
Observe that for small screen sizes <= 2048px, that expression gives the same result as map.transform.width.
For large screen sizes > 2048px, that expression always returns 2048, even though that is less than map.transform.width.
This discrepancy will be confusing the pointCoordinate code in terrain.ts, which uses that expression and a similar one for height to create and query the coords buffer.

See
https://github.com/search?q=repo%3Amaplibre%2Fmaplibre-gl-js+path%3Asrc%2Frender%2Fterrain.ts+devicePixelRatio&type=code

[HarelM]

Interesting, this sounds like there might be other issues related to assuming these are equal.
This might be related to max canvas size maybe? 2048 sounds like the default and might be limiting due to how big the web gl buffer is, maybe?
Just a wild guess...

[HarelM]

BTW, did you have a chance to look at #3878? I've tested it with latest version and the bug still exists...

[HarelM]

Bounty direction: maplibre/maplibre#189