Type def of `Map` constructor option `localIdeographFontFamily` doesn't accept `false` about maplibre-gl-js

[HarelM]

I believe you could define the type as string | false, would that work?

[HarelM]

Probably because of this line:

maplibre-gl-js/src/render/glyph_manager.ts

Line 124 in f6035db

return !!this.localIdeographFontFamily &&

I'm not against changing the code parts to align with the new definition.

[Kanahiro]

maplibre-gl-js/src/render/glyph_manager.ts

Line 35 in f6035db

constructor(requestManager: RequestManager, localIdeographFontFamily?: string | null) {

This constructor only treat localIdeographFontFamily as string | null and this is not correspond to type of the class variable. Other localIdeographFontFamily seems to be string?.

current behavior of localIdeographFontFamily is:

1. not defined: CJK fonts not loaded local or server, because there is default value san-serif.
2. string: load local fonts name defined as string.
3. false: load CJK fonts from server, because this is falsy.
4. defined as undefined: load CJK fonts from server, because this is falsy.

if this has misunderstanding, plz point it :)

[Kanahiro]

#3896

I wrote changes to typedefs and it would work but I cannot understand yet why there are difference in behavior between 'undefined' and 'false'.

understood, #3895 (comment)