Comments (4)
To be clear, I have almost no feelings about this, just want a standard version that we can use by default.
from mr-ui.
👋 I'm going to pick this up.
If there's no objection, I'm going to update ChevronousText
before creating a GoLink
. (It's open for a better name.)
I think it'd be valuable for ChevronousText
to have a boolean iconBefore
prop but by default have a chevron-right
icon. In the GoLink
component, I plan to use the updated ChevronousText
component and give it the option to be bolded/unbolded or dark/light. This is also open for discussion, but I see GoLink
wrapped by an <a />
tag, which may take the user straight to the URL or open a new tab.
This is part of the Accounts team's effort to consolidate our components and abstract them out to the shared libraries of components. For example we're looking to switch out the following Forward
and Back
components:
cc: @angel
from mr-ui.
ChevronousText
does only one thing, really: it puts the icon after text and connects the icon to the last word of the text so that there is no possibility the icon will end up orphaned on another line. So it's only particularly useful for text that might be multiline and will include icons inline with the text. I think that's not the case for GoLink
s (those should live on their own, outside of paragraphs, and be single lines) — so maybe IconText
is more useful precedent for GoLink
(rather than ChevronousText
)?
from mr-ui.
It'd be ideal if they were always single lined texts, but in the past this was not always so due to marketing content, design layout (sidebars), font-size (medium, large), and device size (like mobile view). I'm in favor of having a robust and semi-flexible ChevronousText
and/or IconText
that can handle the icon being before/after the text, multiline, and prevent text wrap if the word next to it just so happens to be really long. This may be way in the future, but this would be beneficial for content that may need to be translated in other languages.
from mr-ui.
Related Issues (20)
- Drop Underreact HOT 1
- Rewrite modal component
- Rewrite popover component HOT 1
- Rewrite controlled-accordion component
- Rewrite control-select using radix select HOT 2
- Remove components that are not needed HOT 2
- Rewrite tabs components using Radix tabs HOT 2
- Plan to migrate components to Radix HOT 1
- Rewrite non radix components
- Rewrite radio/checkbox components HOT 1
- Rewrite range component
- Rewrite control-label component
- Rewrite icon-text component
- Rewrite loader components
- Configure npm build to reference absolute paths
- Allow the `children` prop to be optional HOT 1
- Cursor Jumps to end of input after component is remounted
- Tooltip/Popover component shouldn't require components to be wrapped in HTML markup
- Calls to getWindow() prevent successful use in SSR HOT 2
- Button as child of .prose has blue text
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mr-ui.