Coder Social home page Coder Social logo

manuelsc / lunary-ethereum-wallet Goto Github PK

View Code? Open in Web Editor NEW
366.0 366.0 159.0 10.22 MB

!!DISCONTINUED! DO NOT USE ANY MORE!! [A beautiful, secure and native Ethereum Wallet for Android]

Home Page: https://play.google.com/store/apps/details?id=com.rehanced.lunary

License: GNU General Public License v3.0

Java 91.75% C 8.14% Makefile 0.11%
android android-app ethereum ethereum-wallet wallet

lunary-ethereum-wallet's People

Contributors

erikawunderli avatar kbillings avatar manuelsc avatar marclaporte avatar natodemon avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

lunary-ethereum-wallet's Issues

Free license contradicted by additional conditions

The declared license of Lunary is GNU GPL version 3. GPL v3 §2 says, in part:

This License explicitly affirms your unlimited permission to run the unmodified Program.

That permission is affirmed whether or not the recipient agrees to any further conditions.

The Lunary program notifies the user that access to “the Service”, when run, refuses to continue until additional conditions are agreed:

Your access to and use of the Service [Lunary Ether Wallet] is conditioned on your acceptance of and compliance with these Terms […] If you disagree with any part of the terms then you many not access the Service.

This restriction contradicts the unlimited permission already granted in use of the Lunary Ether Wallet, by granting the GPL v3 to the recipient.

Please remove the click-wrap that refuses access to the program without accepting additonal conditions.

Error when sending sending ether from wallet

When attempting to send ether from a generated wallet to a watch wallet, I got this error message:

rlp: input string too short for common

To ensure all my transaction parameters were correct, I exported my private key and performed the exact same transaction from MyEtherWallet and it worked fine.

Crash when changing price history view

When I change from last 24 hrs, to last 30 days, to last year, the app will crash, each time. No exceptions. Reopening the app, and going to the price history view will open it to whatever I was trying to switch to (e.g. if it crashed when swiping from 24 hrs to year it'll open after the crash in year-view).

I'm running version 1.34 installed from f-droid (although f-droid is now telling me that's an incompatible version, "different signature to installed version", even though I'm 100% sure I installed it in f-droid?); Android 7.1.2

Support for more languages

Lunary is currently available in German, English and Spanish. Any help or contribution with translations and additional language support is always greatly appreciated!

A copy of intern strings can be obtained here: https://github.com/manuelsc/Lunary-Ethereum-Wallet/blob/master/app/src/main/res/values/strings.xml
Feel free to take a look at the german translation to get a feeling of how it is done here: https://github.com/manuelsc/Lunary-Ethereum-Wallet/blob/master/app/src/main/res/values-de/strings.xml

How to
Translate those strings in the strings.xml with the exception being the ToS and put them into a folder called values-xy (xy being ISO 639-1 code for your language. List can be obtained here: https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes ). Once you are done simply create a pull request or mail me your file and we'll check and merge it.

Optional: Specify your real name or pseudonym in your strings.xml under "translator_name" in order to display credit in Lunarys in app about page.

Can't connect to the Network

That's the error I'm getting.

Tried restarting the phone clearing the Lunary cache in System Prefs.

Bummer, because I am definitely connected to the network.

Wallets created pre-1.25 ask for non-existent password

I installed Lunary a long time ago, back when creating a wallet didn't ask me for a password, but now that I've upgraded, it's asking me for a password that I never gave it. What's the recommended way to fix this? Is there a default password that would have been used?

Apparent issues with long passwords

Hi,

I made a wallet some time ago with a rather long password. It was autogenerated, and had special characters in it, if that makes a difference.

I made the keystore in geth. Geth and MyEtherWallet are able to unlock the wallet. Lunary is not.

Cryptographic APIs misuses

I'm a PhD student interested in finding security vulnerabilities in open source projects.

We found a total of 98 warnings (indicating potential vulnerabilities) when running the CogniCrypt static analyzer (*) on Lunary-Ethereum-Wallet (or its library dependencies). We documented each one of these issues in private gists for the sake of confidentiality (non-disclosure).

Can you please let us know whether we can share these gists with you? We are eager to evaluate the perception of developers (e.g. severity of these warnings) and improve Lunary-Ethereum-Wallet's security, and the quality of the reports of static analysis tools.
(*) https://github.com/CROSSINGTUD/CryptoAnalysis

Unable to import a full wallet if the same wallet exists read-only

If I import a wallet in the read-only mode and then try to import it with the private key, it's still a read-only wallet. Its name changes to "Wallet 0xdeadbeef" even though I customized it when it was still read-only but it still doesn't become a full wallet as I cannot send ETH with it. After removing this wallet and importing directly from the private key, everything works as expected.

Add ERC20 Token Send and Receive feature.

This is the best ethereum wallet I've come across in months and but it doesn't have the most important feature which it should have, sending and receiving the ERC20 tokens, yesterday I created and some mainnet tokens but it didn't show, neither in transaction or in token section, plz try to understand, it's really urgent, plzz add ERC20 Token support, we all need it.

Won't watch for other tokens.

The list of tokens (including Ether) on wallets don't seem to be watching for other tokens, and I can't seem to add a watch for any.
Am I missing something or is there no support for ERC20-compliant tokens?

Update on the reqeust to work on Privacy Policy

I am through with the Privacy Policy. I was about working on the FAQs but couldn't access the app. It keeps crashing.

I have made a youtube video for you to see it.
Here is the Link: https://youtu.be/STtUVYOm3uU

Since I am not able to use the app, I will have to stop the FAQs.

Here is the link to the Privacy Policy: https://docs.google.com/document/d/1k5vNWKWEBA9JD26rJPRqp4vpwTlzMV5pWhRepWOM3F8/edit?usp=sharing

Sorry for creating another issue. I had to since you closed the former one I had to open this one. Please go through the file and let me know if you have any corrections so I can work on it before making a pull request.

v1.38 won't open on Android 8.1.0

The app won't launch and Android will show the message:

Lunary has stopped
(option) Open app again
  • Lunary version: 1.38
  • OS: LineageOS 15.1-20181016-NIGHTLY-oneplus3
  • Android version: 8.1.0

Request To Create a Privacy Policy and FAQs,

Hello, I'm Kelita. I would like to contribute to your project. I have been contributing to open source projects lately, and I wish to also add to yours. I noticed your project have no Privacy Policy and FAQs, which I will like to do that for you.
A Privacy Policy lets users of the app know about the policies regarding end-users information collection and use. Also, FAQs will answer some question users might want to have and save both you and the users the stress of asking and you answering the same set of question over and over again.

I would be waiting for your reply and will be glad if this is privileged is given to me.

Doens't display *where* the import folder is

I'm trying to import from Geth. It asks me to put the key in the Lunary import folder, but doesn't say where this is, or give any indication on documentation. How do I need to do this?

Display Address as ERC-67

Hi, I just implemented main-net support into WALLETH and wanted to try out the interoperability of our wallets - but then I saw you use the following format in the QRCode:

iban:

I think this is wrong. The only document I found regarding this is: https://github.com/ethereum/wiki/wiki/ICAP:-Inter-exchange-Client-Address-Protocol
And I find no mention of the style used in Lunary.

I would propose you use ERC-67 - was also giving some arguments in my talk (http://walleth.org/2017/07/01/WALLETH-talk-video/) why I think this is a good idea.

Would also be OK with ICAP - but imho then this should be in the correct style. But then this also makes intent-filters hard and we would clash with other apps that use iban for other purposes - I would prefer ERC-67

Ability to view unencrypted private key

Firstly, thanks for the great wallet app. It's been a great user experience. However, I've created a 2nd wallet and using a password generator to generate password with symbol, now I cannot send fund because it says password invalid, I'm guessing if there's something wrong with symbol encoding.

Is there a way to view my own private key unencrypted like MyEtherWallet?

Thank you.

Build local app

Hi! i will try to build the app and get the error:
"Unsupported Modules Detected: Compilation is not supported for following modules: app, SimpleEtherWallet. Unfortunately you can't have non-Gradle Java modules and Android-Gradle modules in one project."
Could you help me to build it?
I`ve used Android Studio 4 with gradle 3.6.

Add option to set pin code protecting only sending ETH

In the FOSS bitcoin wallet I use, there is a recommended option to set up a pin code that I'll have to enter before spending coins from my wallet. Will it be possible to see such an option in Lunry? I know I can set up a pattern password that will protect anyone from opening the app but sometimes I want to just view my balance or something a like and not nessecerally spend ETH.

The application suddenly stops when deleting multiple wallets.

Actual behaviour

When a user deletes several wallets. Supposedly, that ability must be able to be done.

Expected behaviour

The application suddenly stops when deleting multiple wallets.

Step to reproduce

  • Install and open the application.
  • Generate 6 new wallets.
  • Delete the wallet that was created.
  • Then you will find problems like I have experienced.

Information

  • Devices: Nubia n2 lite
  • Android version: 8.1.0
  • Application version: 1.39

Recording of the bug

https://youtu.be/0FnuZcMBlao

estimateGas uses constant 21.9 gwei gasPrice for estimateGas

GASPRICE being an Ethereum opcode (3a), it is important to supply the correct gasPrice parameter, else you will estimate the wrong amount of gas.

An example of a token that conditions on GASPRICE is TrueUSD, which spends an additional ~21k gas if the GASPRICE is sufficiently high. Supplying insufficient gas will cause the transaction to revert. Even when the amount supplied is sufficient, there is danger that transactions that estimateGas with a different gasPrice than they pay could fail deterministically.

You might also consider padding the estimated gasLimit by 50%, which is what MetaMask does, except for regular eth transfers to accounts that aren't contracts. MetaMask checks if the recipient is a contract using eth_getCode.

"Can't fetch balance" when i go to send, though the wallet clearly knows my balance.

Just as it says. When i open up Lunary, the wallet that was created when i initially ran the app shows my balance--it knows how much eth I've got and the corresponding USD continues to be accurate. So clearly the thing knows how much I've got. However, any attempt to send from that address gives me a notification along the bottom of the UI reading "can't fetch account balance." Suddenly I'm at zero eth the moment I try to move it to a more secure wallet where this nonsense doesn't happen.
Why can't it "fetch" my balance when I hit SEND but seems to have fetched it just fine when I look at it?

Wallet backup

Is there no way to backup the (password encrypted) private key of the wallet?

If backups are already supported, then the feature is insufficiently discoverable. It is good practice for any cryptocurrency wallet to recommend users to backup the wallet, either at creation-time, or after it receives funds for the first time.

mnemonic

Sorry, I can't find where the mnemonic is. Under the trouble, thank you.

Allow to copy the checksumed eth address

Some apps will complain if the address you give them is not checksumed; I think it should be safer to have Lunary copy the checksumed address by default, or at least have an option for that.

Feature request : restore from seed

If i understand correctly, lunary only supports to restore a wallet from a file in an SD card.
If the SD card is missing/distroyed/etc, and i have only the seed phrase, the workaround is to go to "MyEtherWallet", give the 12 word seed phrase, and empty that wallet into a new wallet on the android.

It would be easier if we could simply restore the same wallet directly on the android from the seed phrase.

Use password keyboard when unlocking the wallet

Actually the password is inserted with default keyboard, so for example the Google's one will keep memory of the password as a dictionary's word. This will also reveal the password on clear during insertion.

Wrong German translation

The buttons to send/receive are named confusing.
screenshot_20171203-172650

Button to send ETH should be called: "Ether senden an", the button to receive/request: "Ether empfangen von".

"Can't fetch account balances. Invalid response."

I'm getting this error when I'm trying to refresh my account balance. I see the wallet under the middle wallet tab, but I always get this error when trying to refresh my balance.

Also, I'm unable to export the wallet. I get another error stating "No Full Wallet; Watch only wallets can not be exported."

The wallet is my initial one I made during setup, so I know it's not a watch only wallet.

Using the latest version via F-Droid.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.