Custom tables break db:migrate about manageiq-schema

[NickLaMuro]

I copied metric_rollups_01 to xmetric_rollups_01 as a backup. That caused...

Definitely something that was not consider when doing this, since we are just doing a regexp match on the table name as the original guard for that method, but the fix should be pretty easy.

Just adding a custom table with nothing in it...

create table aaa (id serial);

I think this is a false positive, as it should be create_table (not create table with a space), so the error currently is about the variable table being nil.

[NickLaMuro]

#517 Should solve the original issue. As mentioned above, the other error seems to be a false positive.

[himdel]

create table aaa (id serial);
I think this is a false positive, as it should be create_table (not create table with a space), so the error currently is about the variable table being nil.

Sorry, it's not. That was SQL, not ruby.

[NickLaMuro]

Okay... well you basically are doing something that Rails would never do in the first place:

https://github.com/rails/rails/blob/5-2-stable/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb#L214-L253

Since it always defines a PRIMARY KEY when generating a table.

---

But whatever... solved with the second commit in #517

[Fryguy]

Closed via #517