Add unique index to tags and/or classifications table about manageiq-schema

[kbrock]

Classification#before_save creates the Tag

[Fryguy]

@kbrock Thoughts?

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[kbrock]

@cben is this as simple as:

add_index :classifications, [:parent_id, :description, :id], :unique=>true

I just created that migration but am curious if you are suggesting something else. like dropping the uniqueness constraint - relying upon the tag or something else

[cben]

Yeah that might be enough, as it's similar to existing validation only actually guaranteed.
Need to review creation order — is it always Classification-then-Tag? If a Tag is created first, and then the Classification fails uniqueness, should roll back the Tag. Or just wrap these in a transaction.
Or can postpone this until your quest to merge Classification & Tag, would become no-brainer then :-)

• should also amend tag mapping to catch ActiveRecord::RecordNotUnique as well.
• are there any other places where RecordNotUnique errors would break things?

[JPrause]

@miq-bot remove_label stale

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[Fryguy]

Closing for now, as we can do batch saves a little better in other ways, and we should probably investigate other ways to make the tag mapping table more searchable (such as adding a type or vendor column)