mana_core's People
mana_core's Issues
HHVM Mana_Core issue
We ran into an issue with Mana_Core when we were running it on HHVM.
The error was;
Fatal error: Unexpected object type stdClass. in /data/web/public/app/code/local/Mana/Core/Helper/Js.php on line 101
Line 101 said (in our version):
$fileAction->parentNode->insertBefore($action, $fileAction);
It appears that in this particular case, for whatever reason, $action was null. When running get_class() on $action it gave the helper classname (since it defaults back to the current class when a null value is given as first parameter). But HHVM does a type check and expected a DOMElement instance and therefore it gave the above warning. When $action is null, this obviously does not have to be inserted before the other block. Therefore adding a simple if statement fixed the problem;
if($action) $fileAction->parentNode->insertBefore($action, $fileAction);
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.