makocchi-git / actions-k8s-manifests-validate-kubeval Goto Github PK

Hi,

Thanks for your ghaction pipeline :D
I saw the need to upgrade kubeval, because I needed some new functionality.
I am probably gonna keep my folk up to date. If you would like to merge in my changes, feel free. I can also create a PR if you want.

Thanks again :D

Hello,
thank you for this github action. I think i found a bug. Maybe you can help out with this.
When i have an invalid Kubernetes config. the check is failing with following error:

executed: /kubeval --directories deployments --output stdout --strict=true --kubernetes-version=1.19 --openshift=false --ignore-missing-schemas=true
return code: 1
curl: (6) Could not resolve host: null

i spent some time on this and figured out, that the curl against the github api is failing because no environment variable COMMENTS_URL isset. I added the the environment variable with https://api.github.com/repos/${REPO_OWNER}/${REPO_NAME}/issues/${PR_NUMBER}/comments like its described in the github api docs.

am i missing something?

my configuration looks now like the following:

name: Kubernetes Validation
on: [push]
jobs:
  validation:
    runs-on: ubuntu-latest
    env:
      COMMENTS_URL: https://api.github.com/repos/${REPO_OWNER}/${REPO_NAME}/issues/${PR_NUMBER}/comments
    steps:
      - uses: actions/checkout@v2
      - uses: makocchi-git/[email protected]
        with:
          files: deployments
          comment: true
          token: ${{ secrets.GITHUB_TOKEN }}
          version: 1.19
          strict: true