makairaio / oxid-connect Goto Github PK

When you use the Oxid Model (in any way, don't need to load the article) in an Modifier and get the Long Desciption the AttributeModifier from Makaira throws an exception.

Unknown property $0 in Makaira\Connect\Type\Common\AssignedTypedAttribute

Own Modifier

public function apply(Type $type)
    {
        $objectData = array_merge((array)$type, $type->additionalData);
        $article = oxNew(Article::class);
        $article->assign($objectData);

        $type->longdesc = $article->getLongDescription()->value;
        $type->OXLONGDESC = $article->getLongDescription()->value;

        return $type;
    }

Problem: getLongDescription() internally calls \OxidEsales\Eshop\Core\DatabaseProvider::getDb(); witch resets the Fetch Mode to numeric, DatabaseInterface does not change the fetch Mode back, but the AttributeModifier expects associative Results and can't Map nummeric Results to Class properties.

Possible Workaround:
Put \OxidEsales\Eshop\Core\DatabaseProvider::getDb(\OxidEsales\Eshop\Core\DatabaseProvider::FETCH_MODE_ASSOC); right before the return in own Modifier

Possible Fix:
Ensure that Fetch Mode is set to associative in AttributeModifier or other places

• Assign a product to a category eg. via a product stream
• Add a product directly from the category list to your basket. Use eg. https://demo.makaira.io/oxid6/Alle-Produkte/
• After that you'll find yourself in a totally different category than the category you originated from although the correct cnid is visible in the url

The reason for this is this line: https://github.com/OXID-eSales/oxideshop_ce/blob/d06e90e39f62d32590664153879b478d827d0c44/source/Application/Component/CategoriesComponent.php#L248

When removing a product2category relation (or all relations via Unassign all) the change isn't reflected in the makaira makaira_connect_changes table because no touch is executed.
To fix this you need to write an extension for OxidEsales\EshopCommunity\Application\Controller\Admin\CategoryMainAjax::removeArticle()