mainmatter / ember-cookies Goto Github PK

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml
• The new Node.js version is in-range for the engines in 1 of your package.json files, so that was left alone

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

The issue:

In our application, we first use simple-auth to authenticate and store some session info. Soon after, we read some cookies. When we are in fastboot, the first time we try to read a cookie, it is coming as undefined. After some digging, I think I can see the problem - the _cacheFastBootCookie method is using the same object to write new fastboot cookies that _fastBootCookies computed is using to read back fastboot cookies. That property is _fastBootCookiesCache.

When _fastBootCookies first computes, it checks for the existence of _fastBootCookiesCache. If it doesn't exist, it will read _fastBoot.request.cookies and cache those in _fastBootCookiesCache. If simple-auth happened to have written a cookie before this computed runs, _fastBootCookiesCache will already exist, and it will never read the _fastBoot.request.cookies. Instead it will just read back the cookie that simple auth wrote.

So what I think is needed is for the _fastBootCookies computed to be called before writing a fastboot cookie if that underlying _fastBootCookiesCache doesn't exist. Thoughts?

Update: for anyone else facing this issue, a work-around you can do in your own code is to call a cookie read before doing any simple-auth work, which will cache those fastboot.request cookies before simple-auth can "lock them out" after writing its cookie.

It looks like we can already read() all available cookies and clear() a single cookie. For testing purposes it might make sense to have a clearAll() method as well, to be able to start an acceptance test without any cookies.

Version 2.12.0 of ember-source just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-source is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

DEPRECATION: ember-getowner-polyfill is now a true polyfill. Use Ember.getOwner directly instead of importing from ember-getowner-polyfill

the package is still in the dependencies

😞

Version 2.12.0 of ember-data just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-data is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

DEPRECATION: Use of `merge` has been deprecated. Please use `assign` instead. [deprecation id: ember-polyfills.deprecate-merge] See https://emberjs.com/deprecations/v3.x/#toc_ember-polyfills-deprecate-merge for more details.

"ember-source": "~3.7.0",
"ember-cookies": "0.3.1"

Version 3.3.0 of mocha just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As mocha is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

I'm curious how to set this up, I'm having trouble and have read the docs. Could you give a quick snippet on say, a 48 hour expire time?

Version 1.4.0 of ember-cli-dependency-checker just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-dependency-checker is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

According to CHANGELOG.md and releases page version v0.5.0 has been released.

But https://www.npmjs.com/package/ember-cookies does not have v0.5.0

For some cookies there is null pointer exception in line.
And for this exception my sessionAuthenticated hook in ESA failed.
The cookie cause : " swagger-editor-development-mode:true" with no name

Hey there!

I was just trying this with the latest ember FastBoot (beta.4) and I get the following error:

TypeError: Cannot read property 'indexOf' of undefined at /Users/josemarluedke/Projects/myapp/dist/fastboot/vendor.js:75400:31 at /Users/josemarluedke/Projects/myapp/dist/fastboot/vendor.js:107107:80 at ....

The error points to this line: https://github.com/simplabs/ember-cookies/blob/e4b7cec51da57bd00986f658170e99b6d02d7239/addon/services/cookies.js#L129

Note, version used of ember-cookies was 0.0.7.

The one dependency that you are using ember-getowner-polyfill has a newer version where it supports a new version of babel. This is needed as I am see deprecation warning in my ember app

DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least 
ember-cli-babel 6.6. Version 5.2.8 located: cf2-cli -> ember-cookies -> 
ember-getowner-polyfill -> ember-cli-babel

I would make a PR but not sure that is really needed

…so styles are enforced

This needs tests.

• unit tests
• acceptance tests

Tests need to run both in the browser as well as in Fastboot.

https://github.com/simplabs/ember-cookies/blob/964495965d48f6b2e8e8f9a1729f44204326b1f8/addon/services/cookies.js#L146

Fastboot request protocol is changed to to contain a colon (https://github.com/ember-fastboot/fastboot/pull/119/files). The change should be reflected here as well.

Version 0.13.3 of ember-cli-mocha just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-mocha is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

This line is not working in Interner Explorer
https://github.com/simplabs/ember-cookies/blob/7a7c68d36617ad23978bb6af9481e75f0d3e08a8/addon/services/cookies.js#L9

and babel don't transform this line
https://babeljs.io/docs/plugins/transform-object-assign/#caveats

Version 1.0.0-beta.17 of ember-cli-fastboot just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-fastboot is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

It's currently not possible to use this addon without also including the FastBoot addon. Any attempt to inject the service results in Attempting to inject an unknown injection: service:fastboot errors.

Version 4.2.3 of loader.js just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As loader.js is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

The dependency ember-cli-babel was updated from 7.4.2 to 7.4.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-babel is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

DEPRECATION: ember-getowner-polyfill is now a true polyfill. Use Ember.getOwner directly instead of importing from ember-getowner-polyfill [deprecation id: ember-getowner-polyfill.import]

Can a release be made so the exists method can be used when using the repo via install through npm.

Thanks!!

i try to clear user cookie in my ember app. and the cookie still there...

export default Service.extend({
  cookies: Ember.inject.service(),
  removeCookies() {
    let cookieService = this.get('cookies');
    cookieService.clear('user');
  }
});

its work in chrome. but not in firefox..
whats wrong..

Version 2.2.0 of eslint-plugin-ember just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As eslint-plugin-ember is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 4.2.1 of loader.js just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As loader.js is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

when reading cookies in with fastboot they are being uri decoded twice causing an error if the cookie contains a %. This happens because fastboot uses the cookie package to parse the headers and add to the request object https://github.com/ember-fastboot/fastboot/blob/5a42df54ce3359a33589173d9c79a2236e619ba1/src/fastboot-request.js#L52 cookie calls decodeURIComponent by default when parsing https://www.npmjs.com/package/cookie#decode the value is then decoded again by ember-cookies https://github.com/simplabs/ember-cookies/blob/master/addon/services/cookies.js#L207.

a simple reproduction is

if (!this.fastboot.isFastBoot) {
  this.cookies.write('broken', '%')
}

this.cookies.read('broken')

I know there is a raw option i cannot use this since i'm using ember-cimple-auth. However i also don't think the current behavior is correct regardless since it would require it to be encoded on write and raw on read. I also don't think it would ever be the correct behavior to double decode something since this would change the format unexpectedly if someone intentionally double encoded something for some reason or if it similarly contained a restricted character.

I think the correct fix would be to never use decodeURIComponent when in fastboot

I am happy to submit a PR for this if you agree with the approach

for now my workaround is

_decodeValue(value, raw) {
  if (isNone(value) || raw) {
    return value;
  } else {
    try {
      return decodeURIComponent(value)
    } catch (error) {
      return value
    }
  }
}

This is obviously not great though since it overrides a private method and does not actually handle the double encoding problem but it solved my particular situation

Hi,

Could you release a new version with the latest patchs (including #149) ?

Thank you.

Version 1.3.1 of ember-cli-htmlbars just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-htmlbars is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 1.1.2 of ember-disable-prototype-extensions just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-disable-prototype-extensions is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

in my project with ember-fastboot I have this deprecation error

DEBUG: -------------------------------
DEBUG: Ember             : 3.6.1
DEBUG: Ember Data        : 3.6.0
DEBUG: Ember Simple Auth : 1.8.0
DEBUG: -------------------------------

Version 3.1.0 of ember-cli-eslint just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Hi,

I installed ember-cookies in a fresh project but got an error on run-time saying that lodash was not found in the cookies service. I had to manually add ember-lodash to my project's devDependencies for it to work.

Thanks,
Jorge L

Version 5.2.3 of ember-cli-babel just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-babel is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 2.0.2 of ember-cli-app-version just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-app-version is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Version 1.1.0 of ember-cli-shims just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-shims is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

I've been debugging an authentication issue in our app in FastBoot using ember-simple-auth. Essentially, if you write more than one cookie in FastBoot, the FastBoot Express middleware will only return the last cookie, overwriting the previous cookie each time a new one is added. This particularly affects ember-simple-auth, where if you set an expiration date on your auth cookie, the expiration cache cookie will overwrite your auth cookie, preventing proper authentication.

It's trivial to replicate by writing several cookies in FastBoot and checking the response. You should see a single set-cookie header with the last cookie written.

I personally don't think ember-cookies is doing anything wrong. The way FastBoot provides an API to append headers vs the way it then sets them seems inconsistent. I've opened an issue with more info ember-fastboot/fastboot-express-middleware#33 to hopefully get some feedback on what the intended behaviour is.

A read/write-through cache is needed to mimic browser behavior in FastBoot so that cookies can be read after they have been written. That's not possible out of the box as in FastBoot, cookies are read from the request and written to the response so that cookies that have just been written cannot be read afterwards in the context of the same request.

TODO

• add read/write-through cache so that cookies that have just been written can be read again in FastBoot
• take domain, path and expiration info into account so that cookies that have been written for a different domain or path or that have already expired would not be read from the cache; also secure cookies should not be readable when the current request is not via HTTPS - these are clearly edge cases but when going to some lengths to mimic browser behavior these should be handled for consistency

In my production app RiskMap, we store a lot of cookie information. We like to store certain values in objects for the sake of tidiness, and because it's logical that all data stored in the same object should expire at the same time.

Currently, updating cookie objects is a multi-step process, parsing and stringifying back-and-forth:

let myCookie = this.get('cookies').read('my-cookie');
myCookie = Ember.Object(JSON.parse(myCookie));
myCookie.set('foo-bar', true);
myCookie = JSON.stringify(myCookie);
this.get('cookies').write('my-cookie', myCookie, { maxAge: defaultCookieMaxAge });

This is a pattern we use a lot at RiskMap, so I've extended Ember Cookies to make working with objects easier and more DRY. TL;DR, the above example becomes:

this.get('cookies').writeObjProperty('myCookie', 'fooBar', true);

@marcoow @Turbo87, I'd be interested to know whether you'd be interested in merging some of the following features into Ember Cookies:

Configuration

Serialization

A global way of serializing cookie name and property keys so camel cased attributes can be used in js, but cookie JSON stored in a consistent manner.

// config/environment.js
ENV['ember-cookies'] = {
  serializer: 'dasherize'
}

Default max age/expires

Our user session is set to expire after 30 days. We want most of our other cookies to expire after that, too. The default value can be expressed either as defaultMaxAge or defaultExpires.

// config/environment.js
ENV['ember-cookies'] = {
  defaultMaxAge: 60 * 60 * 24 * 30,
  defaultExpires: 60 * 60 * 24 * 30
}

Object methods

readObj

readObj reads the cookie, automatically parses the object to JSON and asserts whether it is a valid object.

this.get('cookies').readObj('myCookie');
// returns Ember.Object instance || null

readObjProperty

readObjProperty returns the property value from the cookie object.

this.get('cookies').readObjProperty('myCookie', 'fooBar');
// => returns parsed value

Because all cookie objects are parsed into Ember Object instances, we can get deep property values using dot notation:

this.get('cookies').readObjProperty('myCookie', 'fooBaz.isGettable');

writeObj

writeObj asserts whether a POJO or Ember Object instance is passed and stringifies it as JSON before writing:

this.get('cookies').writeObj('myCookie', { fooBar: true }/*, options*/);
// "my-cookie" === { "foo-bar": true }

writeObjProperty

writeObjProperty enables updating an individual property inside a cookie object:

this.get('cookies').writeObjProperty('myCookie', 'fooBar', false/*, options*/);
// "my-cookie" === { "foo-bar": false }

clearObj

clearObj is just an alias for clear, for the sake of consistency.

this.get('cookies').clearObj('myCookie'/*, options*/);
// my-cookie === null

clearObjProperty

clearObjProperty simply sets a property to null, before stringifying and writing.

this.get('cookies').clearObjProperty('myCookie', 'fooBar'/*, options*/);
// "my-cookie" === { }

With version 0.1.0 I get:

DEPRECATION: Addon files were detected in .../node_modules/ember-simple-auth/node_modules/ember-cookies/addon, but no JavaScript preprocessors were found for ember-cookies. Please make sure to add a preprocessor (most likely ember-cli-babel) to in dependencies (NOT devDependencies) in ember-cookies's package.json.

Adding path=/ seems to fix the issue:

- document.cookie = `${cookieName}=; expires=${new Date(0).toUTCString()}`;
+ document.cookie = `${cookieName}=; expires=${new Date(0).toUTCString()};path=/`;

to release #49 into the wild.

The clear method seems to be dropping any options, specifically path, that are passed to it.

It does successfully set the expires option and passes it on the write method but, in my case, path is not getting passed on to the write method.

I am able to work around it by just calling the write method and setting the expire option as clear does, and write still accepts my desired path; However, it would be desirable if clear functioned as described in the documentation.

• Thanks

I have been having issues using the latest release, v0.4, inside an addon that is linked to another app.
Steps:

1. The addon and app have version ember-cookies: 0.4 set as a dependency.
2. Inside the addon I yarn link
3. Inside the app I yarn link addon
4. I ember s in the app and get this error:

Build Error (broccoli-persistent-filter:Babel > [Babel: ember-cookies]) in ember-cookies/clear-all-cookies.js

Requires Babel "^7.0.0-0", but was loaded with "6.26.3". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel.

What I think is happening is that another addon/dependency has Babel 6 declared as a dependency. This is causing the build to sometimes load Babel 6 and not Babel 7.

I ended up downgrading.
Any ideas what can be done?

Version 5.2.2 of ember-cli-babel just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ember-cli-babel is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

When a valid cookie is set that contains = in the value it doesn't work. We discovered this issue because our session cookies always end in =.

document.cookie shows that the cookie is in fact present, meanwhile…
cookies.exists('session') returns false
cookies.read('session') returns undefined

It looks like the issue is where it splits the cookies by "=" and asserts that the length is === 2.
https://github.com/simplabs/ember-cookies/blob/5f83b8486ee19da877cea5c164962ec33c725e5f/addon/services/cookies.js#L196

I'm not sure if there are other edge cases here, but one solution could be to use >= 2 instead. Alternatively you could manually assemble the key and value by doing something like unfilteredCookies.map(c => [c.slice(0, c.indexOf('=')), c.slice(c.indexOf('=') + 1)]).filter(...).

carhartl/jquery-cookie and js-cookie both provided a shortcut to expiration. If you provided expires: <Number>, then it would assume an expiration of days. Would you be agreeable to this sort of feature in ember-cookies?

We could also enhance this significantly by supporting a String value specifying a duration and units. Maybe use the same characters as date formatting to specify units? ex: '3d' or 50M for 3 days or 50 minutes respectively

Thanks for the addon! Loving it and killing off a jquery plugin and bower dependency!