mahdiasd / bottomdialogfilepicker

An android bottom dialog picker for all version of android like telegram | Written in kotlin

Hi there 👋, I'm Mahdi Asadollahpour!

I'm a Software Developer, currently working at Manshour Fanavari (IFTP). I love working on Android apps with Java and Kotlin, as well as building websites with Spring Boot and creating REST APIs using Spring Boot.

🔭 My Interests and Skills

• Create Jetpack Compose app | Stateless and skippable functions
• Android app development with Java and Kotlin
• AR development for application
• Glasses app development
• Website development with Spring Boot
• Create REST APIs using Spring Boot

🌱 What I'm currently learning

• Kotlin Multiplatform

📫 How to reach me

• Telegram: https://t.me/mahdiasd96
• LinkedIn: https://www.linkedin.com/in/mahdiasd96/

bottomdialogfilepicker's Issues

LICENSE

Please add a license file. Otherwise it's unclear if I can use your library in my project. Thanks!

Jitpack

jitpack is not downloading the dependency to be used on the gradle

Permission needed in android API 33

I am getting 'permission needed' toast in android 13 or API 33 emulator, even i manually check the permissions are enabled properly.

No logs nothing.

Permission denied

Why is Permission denied?

Add Uri to FileModel

Thanks again for the library, I was suggesting you add Uri (content URI) to the FileModel, I have not been able to get URI from File or Path in Android 11, 13

MANAGE_EXTERNAL_STORAGE should not be requested.

Your widget requests and uses MANAGE_EXTERNAL_STORAGE (All files access) which makes it unsuitable for most apps. Google Play Store restricts use of MANAGE_EXTERNAL_STORAGE to apps which specifically manage storage:

• File managers
• Backup and restore apps
• Anti-virus apps
• Document management apps
• On-device file search
• Disk and file encryption
• Device-to-device data migration

If the app is not in one of the listed categories, it should not request MANAGE_EXTERNAL_STORAGE permission.

Quote from https://developer.android.com/about/versions/11/privacy/storage

Note: If you publish your app to Google Play, carefully read the notice. If you target Android 11 and declare All files access, it can affect your ability to publish and update your app on Google Play.

Quote from https://developer.android.com/training/data-storage/manage-all-files#all-files-access-google-play

You should request the MANAGE_EXTERNAL_STORAGE permission only when your app cannot effectively make use of the more privacy-friendly APIs, such as Storage Access Framework or the Media Store API. Additionally, the app's usage of the permission must fall within permitted uses, and must be directly tied to the core functionality of the app.

A few suggestions

I'm considering your project to use in https://github.com/tinode/chat
Here are a few things that make it difficult for me to use it:

1. I need camera (CameraX) integration. Telegram's picker has camera as the first tile. Your widget does not. That means I have to create a separate button for camera and if so, I can just use the new PhotoPicker from Google.
2. The [send] button is too much like Telegram and it's not actually sending anything, it's a [done] button, not [send]. Please consider using a more neutral icon, like a checkmark or text [DONE], or make the icon replaceable.
3. Please use standard material design icon for search or make it replaceable.
4. Please consider adding an option to remove circular colored background under icons. Otherwise styling is too much like Telegram.
5. Please consider moving all hardcoded dimension values to Theme, like this:
   https://github.com/mahdiasd/BottomDialogFilePicker/blob/master/FilePicker/src/main/res/layout/item_file_picker.xml#L59
6. If mode is single-selection, then there should be an option to just pick on the first click. I.e. not click on image to select, then click [done], but the first click immediately selects the image/video and returns it to the app. In such a case the selection checkmarks on the image tiles are not needed.
7. There is a visual bug in the UI:

The corners are white, not transparent.

Thank you!

crashing when called in fragment

 Caused by: java.lang.ClassNotFoundException: Didn't find class "com.mahdiasd.filepicker.BR" on path: DexPathList[[dex file "/data/data/moluccus.app/code_cache/.overlay/base.apk/classes3.dex", zip file "/data/app/~~jMZRkVwxQBrHaAVyc7jufQ==/moluccus.app-2MA7ltBC_tWriCclUHS8hg==/base.apk"],nativeLibraryDirectories=[/data/app/~~jMZRkVwxQBrHaAVyc7jufQ==/moluccus.app-2MA7ltBC_tWriCclUHS8hg==/lib/arm64, /system/lib64, /system_ext/lib64]]