magenerds / germanlaw Goto Github PK

Hallo,
I had installed 1.0.3 and have following Problem:
I use m2 with 3 Shops: hu, en and german.
Now I tried to install german law Extension.
Installation successful.
Then I disable the Extension in SHOP->Konfiguration in General and then I activate it in de-shop.
In de everything is shown right, only in the other Shops, the error:
Error filtering template: Element with ID 'after_price' already exists.
Appears.
I want to ask you for help.
Best regards Thomas

The URL http://www.magenerds.com/category/magento-2/feed/ returns a 404, leading to an error in the Magento Backend:

Exception #0 (Zend_Feed_Exception): Feed failed to load, got response code 404

Exception #0 (Zend_Feed_Exception): Feed failed to load, got response code 404
#0 /.../vendor/magenerds/dashboard/Block/Adminhtml/Dashboard.php(55): Zend_Feed_Reader::import(‘http://www.mage...')
#1 /.../vendor/magenerds/dashboard/view/adminhtml/templates/dashboard.phtml(80): Magenerds\Dashboard\Block\Adminhtml\Dashboard->getBlogFeeds()
#2 /.../vendor/magento/framework/View/TemplateEngine/Php.php(59): include(‘/...‘)
#3 /.../vendor/magento/framework/View/Element/Template.php(270): Magento\Framework\View\TemplateEngine\Php->render(Object(Magenerds\Dashboard\Block\Adminhtml\Dashboard), ‘/...’, Array)

Hi,
in the picture you can see, that in product view page with a block for new products (new_list widget), the tax of the new products is the same as the tax of the shown product. This is of course wrong.

getTaxText() is called three times, but it seems three times with the same product id.

I am not sure, that this is a bug in the extension, but maybe somebody does have an idea why this happens.

BR
Chequille

Hi,

Wenn man mehrere Stores und dazupassende Lieferseiten hat und diese den selben Identifier z.B. "lieferung" haben, dann wird die cms_page id in core_config_data gespeichert. Statt "lieferung" steht dann dort Z.B. "lieferung|202" - siehe Anhang
Dies wird dann auch als link ausgegeben und führt zu einem Fehler.

Ich kann es direkt in der Datenbank ausbessern, aber sollte jemand im Bakend hier etwas bearbeiten, wird es wieder überschreiben.

Ich verwende verwende Magento 2.2.2 und GermanLaw 1.1.1

Danke
Tom

Guten Tag,
wir betreiben einen Magento 2 Onlineshop mit insgesammt 3 Kundengruppen.

1. Angemeldete Kunden
2. Angemeldete Firmen ( Firmensitz in Deutschland )
3. Angemeldete Firmen ( Firmensitz außerhalb Deutschlands )

Kundengruppe 3 kauft sämtliche Produkte netto ein. Sprich ohne MwSt. - Leider scheint das Modul den Prozentsatz direkt vom Produkt zu bekommen ohne eine Überprüfung der Kundengruppe zu machen um in diesem zu schauen ob er überhaupt MwSt. zahlen muss.

DIe Preise werden innerhalb Magento perfekt und richtig angezeigt, einzig und allein der Prozentsatz in "Inkl. 19% MwSt., zzgl. Versand" wird falsch wiedergegeben.

Wäre super wenn sich jemand diesem Problem annehmen könnte.

Mit freundlichen Grüßen,
Marcel

Hi,
i tried to fill in following text in Tax-Text: Inkl. 19 % Mwst. zzgl. [ Versand ]
But than the Upper M is disappearing. How can I enter a fix Text with % - Symbol?
I tried already with HTML-eqis but also not going neither the \ to mask it.

Little conflict with firegento/magesetup2

doubles text after price by plugin "magenerds_germanlaw_priceRender" if both extensions are installed

Screenshoot:

Html Code:

Setup:

• Multiple website setup
• The "same" shipping cms page for every website, resulting in that the url-key e.g. shipping is used multiple times within the system
• select for each website the corresponding shipping page (a bit hard as only the title is shown in the dropdown)
• click on the shipping link within the after price text

Result:

• a 404 error page is shown

Expected:

• the shipping page is shown

Additionals:

• the link generated in the after price block has an added '|<>' within the url as the identifier of the page is stored within the configuration value
• the \Magento\Cms\Model\Config\Source\Page::toOptionArray method uses the collections toOptionIdArray() which itself adds the idfield to the value-attribute for the option as the identifier (url-key of the page) is used multiple times in \Magento\Cms\Model\ResourceModel\AbstractCollection::toOptionIdArray

Hi,

in our Magento 2.2.5 system is currently installed version 1.0.4. Strange is that only half or not even half of the labels are translated. Example you can see in the picture attached.

What could here be wrong in after installation?

Thank you.

I think the latest version of GermanLaw is not compatible with Magento 2.2.2 causing errors while installing:

Problem 1
    - Conclusion: don't install magenerds/module-germanlaw 1.0.3
    - Conclusion: don't install magenerds/module-germanlaw 1.0.3|remove magento/framework 101.0.2
    - Conclusion: don't install magenerds/module-germanlaw 1.0.3|don't install magento/framework 101.0.2
    - Installation request for magenerds/module-germanlaw 1.0.3 -> satisfiable by magenerds/module-germanlaw[1.0.3].
    - magenerds/module-germanlaw 1.0.3 requires magento/framework ^100.1 -> satisfiable by magento/framework[100.1.0, 100.1.1, 100.1.2, 100.1.3, 100.1.4, 100.1.5, 100.1.6, 100.1.7, 100.1.8, 100.1.9, 100.1.10, 100.1.11].
    - Can only install one of: magento/framework[101.0.2, 100.1.0].
    - Can only install one of: magento/framework[101.0.2, 100.1.1].
    - Can only install one of: magento/framework[101.0.2, 100.1.2].
    - Can only install one of: magento/framework[101.0.2, 100.1.3].
    - Can only install one of: magento/framework[101.0.2, 100.1.4].
    - Can only install one of: magento/framework[101.0.2, 100.1.5].
    - Can only install one of: magento/framework[101.0.2, 100.1.6].
    - Can only install one of: magento/framework[101.0.2, 100.1.7].
    - Can only install one of: magento/framework[101.0.2, 100.1.8].
    - Can only install one of: magento/framework[101.0.2, 100.1.9].
    - Can only install one of: magento/framework[101.0.2, 100.1.10].
    - Can only install one of: magento/framework[101.0.2, 100.1.11].
    - Installation request for magento/framework (locked at 101.0.2) -> satisfiable by magento/framework[101.0.2].

Maybe this fix could be implemented here as well?
Nogrod@17c6cfd

the following error occures, when frontend inline translation is switched on:

1 exception(s):
Exception #0 (Exception): Warning: sprintf(): Too few arguments in /home/---/public_html/app/code/Magenerds/GermanLaw/Block/AfterPrice.php on line 136

Exception #0 (Exception): Warning: sprintf(): Too few arguments in /home//public_html/app/code/Magenerds/GermanLaw/Block/AfterPrice.php on line 136
#0 [internal function]: Magento\Framework\App\ErrorHandler->handler(2, 'sprintf(): Too ...', '/home/---..', 136, Array)
#1 /home//public_html/app/code/Magenerds/GermanLaw/Block/AfterPrice.php(136): sprintf('{{{Inkl. %s MwS...', '19%')

could you confim this Bug?

Hi,

I tried to find myself, but I was not successfull.

Baseprice is showing as well on the catalog list and grid view page.
But the tax-details are not shown.
There is a div with class="tax-details" in the html code, but nothing in there.
Maybe a configuration fault, but I do not know what it could be.

Any ideas?
BR
Jürgen

Hi,

mit installation von GermanLaw wurde auch ein Cookie Hinweis installiert, ich habe bereits eins in meinem Theme und würde lieber dieses verwenden. Wie kann ich den Cookie Hinweis von GermanLaw deaktivieren?

Danke

Philipp

Inside productdetails, but not in lists / categories, $block->getTaxText() ( \Magenerds\GermanLaw\Block\AfterPrice ) is executed twice, though it is not directly from inside the module which I searched through. Maybe Magento´s behaviour changed (also because Magenerds/BasePrice#2 is a similar issue in another module)...?

For a quick and dirty fix you can use css as seen in the screenshot
.tax-details + .tax-details { display: none; }

Best regards, Pierre.

Hi,
the 5 cms pages are not generated anymore under Magento 2.2.1

Already know error?

BR
Jürgen

Bitte checken ob eine CMS Seite existiert bevor diese mit dem Dummy Text angelegt wird. Meine fertiges Impressum und AGB sind nun leider weg :(

Hello please add support for > Magento 2.3.5

I get following failure:

magenerds/germanlaw 1.2.1.1 requires magento/framework ^100.0.0|^101.0.0|^102.0.0 -> no matching package found.

Magento use for 2.3.5 framework 102.0.5

Tax rate is showing up multiple times in product page, in simple/configurable products it is showing up twice, one next to price and one next to submit button.

As we know that grouped products has issues with tax rates (magento bug) and in this case it is not showing tax rate percentage, but it should show atleast 0%, for example there is a text "Tax rate %s" on products like simple/configurable it would show "Tax rate 20%" on grouped it shows up like this "Tax rate"

Tax rate text is showing up twice for every grouped product and one extra at the end of grouped product table.

Hallo!
Bei der Installation des Moduls müssen Sie beim Lesen der CSV-Datei explizit einen Begrenzer im Konstruktor angeben. Andernfalls wird die Datei in einigen Situationen nicht analysiert:
$this ->_csvReader->setDelimiter(',');
Außerdem müssen Sie das Vorhandensein von Seiten mit diesen IDs überprüfen, da vorhandene Seiten überschrieben werden. Hier ist ein Beispiel für den Optimierungscode:

public function install()
{
$fixtures = ['Magenerds_GermanLaw::fixtures/pages.csv'];

    foreach ($fixtures as $fileName) {
        $fileName = $this->_fixtureManager->getFixture($fileName);
        if (!file_exists($fileName)) {
            continue;
        }

        $rows = $this->_csvReader->getData($fileName);
        $header = array_values(array_shift($rows));

        foreach ($rows as $row) {

            $cmsData = array_combine($header, $row);

            if (!$this->checkIfPageExists($cmsData['identifier'])) {
                /** @var $page \Magento\Cms\Api\Data\PageInterface */
                $page = $this->_pageFactory->create()
                    ->load($cmsData['identifier'], 'identifier')
                    ->addData($cmsData)
                    ->setStores([\Magento\Store\Model\Store::DEFAULT_STORE_ID]);

                $this->_pageRepository->save($page);
            }

        }
    }
}

public function checkIfPageExists($identifier)
{
    $cmsPage = $this->_pageFactory->create();
    $cmsPage->load($identifier);
    if ($pageId = $cmsPage->getId()) {
        return $pageId;
    } else {
        return false;
    }
}`

PS:
Hier wird die vorherige Datei heruntergeladen
$fixtureFile = 'Magenerds_GermanLaw::fixtures/tax_rules.csv';
$fixtureFileName = $this->_fixtureManager->getFixture($fixtureFile);
if (!file_exists($fileName)) {
continue;
}
$rows = $this->_csvReader->getData($fileName);
$header = array_values(array_shift($rows));

Hi,
as of the new regulations, customer does have to agree as well when creating an account, that he is doing that knowing about the usage of his data.

This means as well in the part when creating an account, there must be a checkbox filled to agree to the privacy policies.

Did you or somebody else does have a solution for this issue?

Best regards,
Jürgen

Hi,
the fix you made is only working for simple products.
Am using the latest release 1.0.13 and Magento 2.2.1

It is not working for configurable products.
I get always Tax and Baseprice shown two times.

The second baseprice rendering is always taking the price from the parent product.

Any idea why?
BR
Jürgen

Due to the version requirement for magento/framework the installation of the magento
security update 2.2.1 can't installed via composer.
Is it possible to enhance the requirement statement for magento/framework to 100.0.|100.1.|101.0.* ?

  - magenerds/germanlaw 1.0.12 requires magento/framework 100.0.*|100.1.*|101.0.0 -> satisfiable by magento/framework[101.0.0, 100.0.2, 100.0.3, 100.0.4, 100.0.5, 100.0.6, 100.0.7, 100.0.8, 100.0.9, 100.1.0-rc1, 100.1.0-rc2, 100.1.0-rc3, 100.1.0, 100.0.10, 100.0.11, 100.1.1, 100.0.12, 100.1.2, 100.1.3, 100.0.13, 100.1.4, 100.0.14, 100.1.5, 100.0.15, 100.1.6, 100.1.7, 100.0.16, 100.0.17, 100.1.8, 100.1.9, 100.0.18, 100.0.19, 100.1.10].
   - Can only install one of: magento/framework[101.0.1, 101.0.0].
   - Can only install one of: magento/framework[101.0.1, 101.0.0].
   - magento/product-community-edition 2.2.1 requires magento/framework 101.0.1 -> satisfiable by magento/framework[101.0.1].