madskristensen / browsersync Goto Github PK

View Code? Open in Web Editor NEW

12.0 12.0 7.0 455 KB

A Visual Studio extension

License: Other

C# 60.60% JavaScript 39.40%

browsersync's People

Contributors

Stargazers

Watchers

Forkers

modulexcite doggy8088 jorik041 codecopy paulmontecillocabral starnamer moneyunoffical

browsersync's Issues

Visual Studio 2022 Support

Installed product versions

Visual Studio: 2022 All Versions

Description

Make the extension available in Visual Studio 2022.

Steps to recreate

Download the extension installer.
Run the installer.

Current behavior

Message that it is already installed to all applicable products appears even though it is not installed in Visual Studio 2022.
It is also not listed in Online Extensions in Manage Extensions Visual Studio 2022.

Expected behavior

Installs and works in Visual Studio 2022.

Note: Sorry for the all the extra details. I probably could have stopped with the title on this one.

Sync checkbox groups not working

Consider this markup:

<input type="checkbox" name="check" value="first" />
<input type="checkbox" name="check" value="second" />

The name attribute is the same for both elements. This is typically used for radio button groups, but can be used for checkboxes too. However, the mechanism for setting the right value for checkboxes is different than for radio button groups.

Sync check/radio boxes and dropdowns

Today, only <input type="text">, <textarea> and [contenteditable] elements are supported for synchronization. This should be expanded to include other form field elements

i want to know what does this use for?

Form input sync doesn't play well with knockout.js bindings

"Typing in input fields is synced across browsers"

In a knockout.js app, the view model isn't updated with the synced form values. This is true for both the value and textInput bindings.

Firing the input.change event causes the view model to be updated. For example, typing the following line into the browser console after the values are synced works:

$("input").change();

Would you consider a way to either support this out of the box, opt-in via configuration or perhaps even add a client-side hook for developers to execute client-side logic after values are synced?

Support contenteditable

Navigation sync doesn't work

Looks like you have a typo in the function call for sending the navigation sync:

BrowserSync/src/BrowserLink/SyncEngine.js

Lines 37 to 50 in b9e4151

    
           function sendSyncNavigate() { 
        
               browserLink.invoke("Navigate", window.pageXOffset, window.pageYOffset); 
        
           } 
        
           function connectionHandler() { 
        
               document.onkeydown = function (e) { 
        
                   var evt = e || event; 
        
                   if (evt.altKey && evt.ctrlKey && evt.keyCode === 13) { 
        
                       evt.preventDefault(); 
        
                       SendSyncNavigate(); 
        
                   } 
        
               };

Your function is called sendSyncNavigate but you call SendSyncNavigate (note the capital S on Send).

	function sendSyncNavigate() {
	browserLink.invoke("Navigate", window.pageXOffset, window.pageYOffset);
	}

	function connectionHandler() {

	document.onkeydown = function (e) {
	var evt = e \|\| event;

	if (evt.altKey && evt.ctrlKey && evt.keyCode === 13) {
	evt.preventDefault();
	SendSyncNavigate();
	}
	};