machine-drivers / machine Goto Github PK

View Code? Open in Web Editor NEW

This project forked from docker/machine

25.0 25.0 16.0 19.39 MB

Machine management for a container-centric world

License: Apache License 2.0

Makefile 0.69% Go 93.79% Shell 5.49% Dockerfile 0.04%

containers docker libmachine virtualization vm

machine's People

Contributors

Stargazers

Watchers

Forkers

anjannath crc-org abaelhe blueelvis olivbour medyagh jhixson74 sharifelgamal vinu2003 lingsamuel spowelljr hjiej devicemanager cvila84 luiz-monad mojitavoni

machine's Issues

Provide a way to fix `are you getting rate limited by Github?`

For example, support environment variable GITHUB_TOKEN.

Add Amazon Linux provisioner.

source: minishift/minishift#2421 (comment)

As per this repo there is no provisioner for amazon linux: https://github.com/machine-drivers/machine/tree/master/libmachine/provision

Unable to select Default Switch by name in case of localized Windows

Note: Copied from docker#4429

When trying to select the switch using a localized string, eg. "Przełącznik domyślny" (meaning 'Default Switch') for Polish, the selection will fail with:

Error starting the VM: Error creating the VM. Error with pre-create check: "vswitch "Prze\u0088¥cznik domy\u0098lny" not found"

The problem lies with:

machine/drivers/hyperv/hyperv.go

Line 283 in 1e3b6b6

if name == d.VSwitch {

Besides a string, it should desirably also check for the switch by ID, as this value is static:

PS> Get-VMSwitch -Id c08cb7b8-9b3c-408e-8e30-5e16a3aeb444

Related: minishift/minishift#2096

/cc @gbraad

docker-machine is closed, so if we want it to continue, we need to start releasing

see docker#4537

I'm also wondering if toolbox is needed too - there are users that don't use hyper-v, or simply have different goals :/

update parallels fork

can someone with push access please update the https://github.com/machine-drivers/docker-machine-parallels fork. There are a set of new changes I'd like to incorporate into a future PR. Thanks!

Change package path for github.com/codegangsta/cli

This package is being used in several places but now has been renamed to https://github.com/urfave/cli.

Replace samalba/dockerclient with engine-api/client

As mentioned in docker-archive/classicswarm#1879, https://github.com/samalba/dockerclient is outdated and no longer maintained.

The official client is available here https://github.com/moby/moby/tree/master/client

VirtualBox: Host-only Adapter deprecated in macOS 13 (Ventura)

We've been getting a large number of reports of users on minikube unable to use the VirtualBox driver on macOS 13. This seems to be due to Host-only Adapter being deprecated, it will need to be replaced with Host-only Network. For backwards compatibility I'm assuming we should only use Host-only Network if the user is on macOS 13 or later.

kubernetes/minikube#15274

Is there any reason retrieve IP every time in Hyper-V?

Inside Start, we already set IPAddress

machine/drivers/hyperv/hyperv.go

Lines 362 to 372 in 4f91040

    
           func (d *Driver) Start() error { 
        
           	if err := cmd("Hyper-V\\Start-VM", d.MachineName); err != nil { 
        
           		return err 
        
           	} 
        
           	ip, err := d.waitForIP() 
        
           	if err != nil { 
        
           		return err 
        
           	} 
        
           	d.IPAddress = ip

But inside GetIP, we retrieve IP instead of use cached value.

machine/drivers/hyperv/hyperv.go

Lines 433 to 453 in 4f91040

    
           func (d *Driver) GetIP() (string, error) { 
        
           	s, err := d.GetState() 
        
           	if err != nil { 
        
           		return "", err 
        
           	} 
        
           	if s != state.Running { 
        
           		return "", drivers.ErrHostIsNotRunning 
        
           	} 
        
           	stdout, err := cmdOut("((", "Hyper-V\\Get-VM", d.MachineName, ").networkadapters[0]).ipaddresses[0]") 
        
           	if err != nil { 
        
           		return "", err 
        
           	} 
        
           	resp := parseLines(stdout) 
        
           	if len(resp) < 1 { 
        
           		return "", fmt.Errorf("IP not found") 
        
           	} 
        
           	return resp[0], nil 
        
           }

machine-drivers / machine Goto Github PK

machine's People

Contributors

Stargazers

Watchers

Forkers

machine's Issues

Provide a way to fix `are you getting rate limited by Github?`

Add Amazon Linux provisioner.

Unable to select Default Switch by name in case of localized Windows

docker-machine is closed, so if we want it to continue, we need to start releasing

update parallels fork

Make an initial release

Change package path for github.com/codegangsta/cli

Replace samalba/dockerclient with engine-api/client

VirtualBox: Host-only Adapter deprecated in macOS 13 (Ventura)

Is there any reason retrieve IP every time in Hyper-V?

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	func (d *Driver) Start() error {
	if err := cmd("Hyper-V\\Start-VM", d.MachineName); err != nil {
	return err
	}

	ip, err := d.waitForIP()
	if err != nil {
	return err
	}

	d.IPAddress = ip

	func (d *Driver) GetIP() (string, error) {
	s, err := d.GetState()
	if err != nil {
	return "", err
	}
	if s != state.Running {
	return "", drivers.ErrHostIsNotRunning
	}

	stdout, err := cmdOut("((", "Hyper-V\\Get-VM", d.MachineName, ").networkadapters[0]).ipaddresses[0]")
	if err != nil {
	return "", err
	}

	resp := parseLines(stdout)
	if len(resp) < 1 {
	return "", fmt.Errorf("IP not found")
	}

	return resp[0], nil
	}