macaw-cad / sxa-umbrella Goto Github PK

Small coding error, working was correct. So more a code smell.

For Scriban deployment to a site always all Scriban files are uploaded. Optimize the initial deploy to do a single deployment per Scriban collection.

When two processes try to generate the same item at the same time it can occur twice, which can lead to issues with upload of Scriban files

There is currently a delay in upload, but it is not good enough to prevent 500 errors. Increasing the delay will make upload time longer. Implement retry?

It is not clear from the gulp output what server files are deployed to - display the server name

Patterns are used for cleanup of the scripts and styles folders in the themes. The src folder can include a scripts or styles folder as well. Those may not be removed. Ensure that all files in the src folders are excluded from cleanup. This means that rimraf cannot be used anymore, because it can't exclude using glob patterns. Move to del-cli to handle this.

People see commands in the package.json and execute them before configuring Sitecore correctly to be able to handle these commands (enable Creative Exchange endpoints, enable remoting). Prevent these "questions" by moving a configuration quickstart to the top of the documentation.

All flags images are compiled into a sprite image called sprite-flag.png. Don't sync the individual flag files to Sitecore.

Sort the item paths of the Scriban items in ascending order, so parent items are created before subitems.

In getScribanFiles() return: return results.sort((a, b) => a.length - b.length);

Breaking issue: fix is in tools\util\requestChangeFile.js, line 9: use script=${destinationPath} instead of script=${context.destinationPath}.

# generated styles
/Media Library/**/styles

# generated scripts
/Media Library/**/scripts

Also excludes styles/scripts folder within the src folder - make more specific and add to documentation.

When (due to issue #13) an item occurs twice with the same name in the scriban tree (e.g. item.scriban) the following error may occur:

Scriban import failed for Scriban files in the folder 'Rendering Variants/DMP Site/-/scriban': Response code 424 (Method Failure)

Quick-fix: remove the double item.