m0rtadelo / ntlm-client Goto Github PK

Somehow the event response.on('end') was not fired sometimes, so request was not resolved even the request already finished.

I think it'd be good if we can handle this case by handle when connection closed. Maybe by adding this.

response.on('close', () => {
  if (result.resolve) {
    delete result.resolve;
    res(result);
  }
});

This library doesn't seem to support Transfer-Encoding: chunked. Result is limited to the first chunk

I use this code:

const client = new NtlmClient();
const ntlmData = await client.request({
    url: 'https://example.com/Menu',
    method: 'GET',
    debug: true,
    disableRedirect: false,
    insecureHTTPParser: false, // true, false or undefined do not affect error
    authMethod: ['ntlm'],
  },
  'USER',
  'PASSWORD',
);

And I get this error:

ntlm-client@m0rtadelo [request] init request
ntlm-client@m0rtadelo [setOptions] options setted!
ntlm-client@m0rtadelo [Fetch] request init for url: https://example.com/Menu
ntlm-client@m0rtadelo [Fetch] requesting (1/8) https://example.com/Menu
ntlm-client@m0rtadelo [setHeaders] headers = {}
ntlm-client@m0rtadelo [Fetch] error on request!
[Nest] 157  - 01/26/2023, 5:43:21 PM   ERROR [ExceptionsHandler] unable to get local issuer certificate
Error: unable to get local issuer certificate
    at TLSSocket.onConnectSecure (node:_tls_wrap:1532:34)
    at TLSSocket.emit (node:events:527:28)
    at TLSSocket.emit (node:domain:475:12)
    at TLSSocket._finishInit (node:_tls_wrap:946:8)
    at TLSWrap.ssl.onhandshakedone (node:_tls_wrap:727:12)

But if I use curl with the -k option, which disables certificate verification, then I get the correct answer:

curl -X GET -k https://example.com/Menu --user "USER:PASSWORD" --ntlm

It works with node 20 and legacy MS Exchange 2013 if

1. set node flags:

node --openssl-legacy-provider --tls-min-v1.1 --tls-ciphe
r-list=DEFAULT@SECLEVEL=0 main.js

2. modify ntlm.ts: function: decodeType2Message

Replace
if (str.hasOwnProperty('headers') && str.headers.hasOwnProperty('www-authenticate'))

to

if ('headers' in str && str.headers.hasOwnProperty('www-authenticate'))

(It looks like 'headers' is inherited property now)

Thanks

Redirection is not working, because result.headers have lowercase keys. So eveywhere 'Location' is requested from result.headers, it should be 'location' (toLowerCase)

I'm attempting to test the following call in my environment (updating the necessary fields):

const response = await client.request('http://ntlm.protected.data/items?id=26',
  'user', 'pass', 'workstation', 'domain'
);

When I make the call I get the following error:

Uncaught Error: error:0308010C:digital envelope routines::unsupported

Stepping through the stack trace the it appears the issue happens when a hash is being created for the password.

I've looked online and it seems like something changed with Node in version 17 that causes this problem.