lverhulst4321 / planz Goto Github PK

The configuration table editor uses foreign keys to populate reference table drop-downs.
However, if a referenced (parent) table is empty, the linking (child) table will not display in the configuration table editor.
This is fairly reasonable behaviour, since it won't be possible to add rows to the child table until the parent table is populated. However, currently no error message is displayed, so it isn't obvious why the table isn't displaying.
This problem could be largely avoided by ensuring there is at least one sample row in all referenced tables. However, in the long term we should try adding logic to display a message such as "You cannot edit table X until table Y has been populated."

Levitation (Eastercon 2024) made much heavier use of this system for AV Tech, and some of the reports listed can probably be removed, after all, why keep code that serves no purpose.

Required Room Services 'field' seemed hardly used, so it may not be useful.

The following reports were either empty, or so sparsly populated that they weren't useful:

• AV Services
• All Services
• Hotel Services
• Program Services
• Session Features
• Session Services
• Session Services by service

I didn't think of this when I updated the Install doc, but it doesn't mention anything about the react app.

I think it should at least contain a link to the Readme of the react app.

I also wonder should we include an initial build of the React app in the /webpages/dist directory, so people can just grab the application from GitHub and be ready to go?

Configuration tables fail to load in the configuration editor if they have foreign keys.
The following error gets logged:
PHP message: PHP Fatal error: Uncaught TypeError: strpos(): Argument #1 ($haystack) must be of type string, array given in /var/www/html/webpages/SubmitEditConfigTable.php:272

Caused by change to the way foreign keys are processed in SubmitEditConfigTable.php.
Zambia stored keys in a string the format REF_COL_NAME:TABLE_NAME.COLUMN_NAME.
PlanZ stores them in an array instead, but the code to split the string back out is still present.

I've found that the Search Sessions page is not filtering the sessions as requested. For example, when the Track of Literature is selected, all sessions are still being displayed.
I've done a little bit of review, but don't see any reason why this is happening.
I was wondering if any else is seeing this issue?

In isolation I like the name. But having talked to a bunch of people at this year's Eastercon about the fact they're using this, they naturally google it and the first result is https://en.wikipedia.org/wiki/Plan_Z - a Nazi plan. No one seriously thinks it is named after that, and they can see the route from Zambia to Plan Z, but it does sour people's first impression.

I've been asked to add an Expand All button to the participant's Session Search Results page.
File: PartSearchSessionsSubmit.php

As far as I can tell, the page is currently using the bootstrap collapse function per session. There is reference to a multi target collapse option in the bootstrap docs. https://getbootstrap.com/docs/4.5/components/collapse/

Before I spend more time on this, I would like to know if this looks like a good route to go down and try. Thoughts?

Thanks!

The code for PR #36 causes a different bug now on the Chicon 8 dev server. No issues on my test server.

The code in the fetch_participant.php is using mysqli_fetch_object and this message is saying, I think, that it should be mysqli_fetch_array.

Thoughts?

Table bad.

Report no run.

Tears.

I have discovered that there is a bit of an issue between our new naming conventions for tables and with the config table editor. The config table editor has specific code regarding tables that have references to other tables (like RoomHasSet). Our new naming conventions doesn't follow the usual Zambia naming conventions and so the config table editor doesn't work for any new tables with references. As best as I can tell.

I would appreciate it if someone else can check this out and verify what I am thinking is the issue.

I've made a new branch available called: adjust-public-grid-report
The public grid report is something that I created years ago for Capricon and then shoehorned in for Zambia. It is not pretty, but is functional. I'm working (slowly) on making it better.
Anyway, I had added a field in the Rooms table for divisionid, but I have decided to do something different. I've made a table called room_report_group to identify a "report group" and then a table called room_report_group_has_room to link a set of rooms to a report group.
After updating the config table editor code, I find that I get an error when trying to edit the room_report_group_has_room table and I believe it's due to the naming convention differences.

Several conventions I'm involved with have used program data to for streaming of virtual/hybrid program, and for displaying future program items on room projector. These take a JSON feed, and are very close to the KonOpas/ConClár feeds.
I would like to add optional OBS feeds to the KonOpas/ConClár exports, with configuration settings to control them.

I've been working on a page for editing the site configuration.

On load it carries out the following steps:

• Verifies the user has admin permission.
• Reads the db_name_sample.php file.
• Parses the file, separating any lines before the first define.
• Displays a HTML table listing the setting name, the default value (from sample file), the current live value (from the current active constants), and any comments following.

When Save pressed to save changes, it also carries out the following steps:

• Load the current live db_name.php to get the initial lines before the first define.
• Copy the current live settings to db_name_backup_N.php where N increments by 1.
• Save the prefix lines from the form submitted values with names and comments from sample file to a temporary file.
• Rename temporary file to db_name.php.
• Catch and display any errors when saving.

I'm not quite ready to open a pull request, but I've uploaded the current version to a branch: https://github.com/lostcarpark/PlanZ/tree/ConfigSettings

I'd appreciate if anyone could try it out and provide feedback.

Overall, I'm very happy with how well it works, and it gives admin users the ability to edit configuration without needing to edit the file directly, without needing access to the webserver back end.

Some considerations:

• Currently anyone with the Administrator role can access the page. It may be preferable to create a new privilege so access can be taken away, as not all sites may want to use it.
• Any custom defines not in the sample file will not be retained. This is deliberate, as I feel keeping the sample file in step with the active one is crucial, but if sites are using custom settings, it could cause problems.
• The form does not use an XML template. Adding one would add significant development effort for little gain.
• There is not much validation of the submitted form values at present, as it's assumed it will only be used by trusted administrators. It may be worth adding some additional checks.
• At present the type of the setting is inferred from its value. We may want to add support for additional types, or add more explicit typing, perhaps using the comments.
• I prepare messages when saving the file. However, due to the page redirect, these never get displayed. It would be nice to find a way to display the message after the page reload.

There are several places that Wiscon branding is present on the Brainstorming page.

Things that are working at present:

• Correct site logo from theme displayed in header.
• "Submissions are open for programming for ."

Things that need improving:

• Favicon currently has Wiscon logo. Would be nice if also could take the site theme one. Presumably the same mechanism used for the header logo should work.
• Navigation bar has Wiscon links hard coded. I think this is already available to app, so hopefully this can be added to navigation bar.
• Footer bar has "site maintained by SF3..." hard coded. It would be good if this text could either be defined in db_name or CustomText.
• Sidebar "What are we looking for? WisCon...". Ideally this should be coming from CustomText.
• Page <title> currently hard coded to "WisCon Panel Idea Submission/Brainstorm".

I'm hosting several convention PlanZ sites (although only one is using Brainstorming so far). It would make my life easier if I can deploy one Brainstorming "build", and have customisation through settings/tables.

I would like to add a participant's social media links to the db and allow the participant to fill out these fields.

I am considering adding the fields to the ParticipantDetails table. Or I could do a separate table.

Fields I am thinking to add:
facebook_link
instagram_link
linkedin_link
tiktok_link
twitch_link
twitter_link
website_link
youtube_link
other_link

I am also considering where to allow the participant to enter the values. I could modify the profile page and add a section for the links. (I like this best.) Or I could add a separate page. Or I could modify the personal details page, but it's currently labeled as "Optional Demographic Details", which would need to be changed.

Thoughts?

The empty db is missing the patches since 75ZED, and the instructions don't tell you that you should run the missing patches. I think either the empty db should be kept up to date, or the instructions should be updated to tell you about the patches.

I am having an issue with the "Show Bio" button at the bottom of the Assign Participant screen.
File: StaffAssignParticipants.php

I pull up a session. I then pull up a person who has a bio and nothing happens when I click the button. No error in the console, no error I can see. I checked on my old version of Zambia that we used for Capricon and it works fine.

Can others replicate the issue? Any ideas?