luxonis / depthai-bootloader-shared Goto Github PK

Three classes within dai::Response:* have a success member that is later directly tested in branching like if(resp.success) ...
However, there are multiple codepaths in which success is never initialized and therefore holds a random garbage value.
Which then leads to failures in branching.

Easy fix. The classes should set a default init of 0 aka false.

Setup

• all
• depthai-bootloader-shared main and depthai-core main

Repro

Found during code cleanup I'm in process doing. Here is one example...

The branch which tests if(resp.success) https://github.com/luxonis/depthai-core/blob/c49cd08cb1cad7d526ca2c2a2b561f0dcfa7020d/src/device/DeviceBootloader.cpp#L691

    Response::GetBootloaderConfig resp; // doesn't initialize anything to any value
    receiveResponse(resp); // fail on first line of func and returns `false`
    if(resp.success) { // therefore `success` was never initialized and if() tests random garbage value

Expected

Initialize all member fields. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c41-a-constructor-should-create-a-fully-initialized-object

Fix

I have a PR forthcoming, fix for this specific case is easy.

The develop branch is several months behind main.

Should I submit my PR to the old develop or the current main or ??