Coder Social home page Coder Social logo

luxoft / ivilink Goto Github PK

View Code? Open in Web Editor NEW
16.0 16.0 6.0 56.53 MB

iviLINK application connectivity stack for in-vehicle infotainment

Objective-C 1.26% C 60.75% C++ 22.84% Assembly 5.22% Perl 3.30% JavaScript 0.89% Shell 4.11% Java 1.33% PHP 0.01% Smalltalk 0.04% Awk 0.12% Prolog 0.13% eC 0.01%

ivilink's People

Contributors

kostiakhait avatar predatorybird avatar promihu avatar vplachkov avatar ysafina avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ivilink's Issues

Poor english

The documentation is written in poor english. Review and correction by a native speaker would be great.

can't build log4cplus (INSTALL not found)

I experience this error when I run make:

Makefile.am: required file `./INSTALL' not found
Makefile.am:   `automake --add-missing' can install `INSTALL'

I'm running Ubuntu 12.04

Repository structure, binaries and sources

Usually, a git repository contains only sources. Documentation is handled separately.
PDF documents are usually hosted on a website.
Doxygen documentation is rarely checked into the source repository.

Proposals:

  • Add a separate repository for generated documents (PDF and doxygen) and/or add a branch gh-pages in this repository (http://pages.github.com/) to setup http://ivilink.github.com with api documentation.
  • If source documents for PDF are plain txt files, they can be checked in.
  • Remove doc folder from the main repository and move all the sources to root folder.

Additional comments:

It would be great if luxoft provided a full git history, not just "check in version 1", "check in version 2" commits.
Providing only major versions on github is no different than hosting an archive with sources on a website.

What is the license of this software?

I believe this software is open source but it ought to be clear to those who are unfamiliar with the licensing terms and who may want to use the software.

Exceptions

Does ivilink use exceptions?

I mean

char *someVar = new char[  0xDEAD ];
strcpy( someVar, "I can fly" );

If new fails, what's going to happen?

Android

Any instruction on how to build ivilink for android is missing.

Make more atomic commits

You don't need a GitHub repo to release sources a few times a year.
GitHub is all about collaboration. It's not just a hosting for your sources.
I don't see much collaboration here.
You could just distribute zipped sources via ivilink.net.

Code guidelines

Hello,

Do you have any coding styles?

I see that you've got a couple of styles like

std::list <std::string> ReadFile(const std::string name);

AND

CError NegotiateChannel(std::string tag, UInt32 & channelId);

What is more, sometimes I encounter tabs, sometimes spaces.

Secondly, are there any agreements what should be used for a project? For instance, exception free libraries, pthread as a library from ITC etc.

Generated documentation (Doxygen)

It's sad that iviLink maintainers decided to check in the generated documentation into source control.
It would be better to handle it differently. For example, it could be generated as a part of the build process.
Or in a separate repository: http://ivilink.github.com/api_doc.html
Also, there is no version in the resulting documentation, which should be added to the Doxyfile.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.