lutris / lutris-dashboard Goto Github PK

While some installers should be rejected outright (piracy, shady sources, etc), more often I want to follow up with the submitter and and questions or request changes.

For example, recently someone submitted an installer for GOG's Windows version of Another World. There is already an installer for GOG's native version, so our policy is not to accept the Windows version in that scenario… unless it has features that the native one lacks. So in this case, rather than reject outright, I'd like to ask the submitter why they wanted the Windows version when the native one already exists. Otherwise I have to choose between accepting an unnecessary installer, rejecting a useful installer, or doing the work of researching why the Windows installer may be needed (In this case I chose to do nothing, and someone else accepted the installer later, so the submission is no longer available).

It would be nice to have a third option, something like "Reject with reason" or "Request information/changes", that allows moderators to send a message to submitters and preserves the installer. The message could be sent through email or appear on the submitter's dashboard; the submission could either be included in the message or set back to draft status.

Once a submission/draft is accepted/deleted the page exits back to the submissions page. Instead, it should load another draft/submission if there are any available.

With the way it is now you have to review the installer, accept/delete installer, go back to game page, reload to refresh review button, and review the remaining edits. Repeat that process until there aren't any left.

It's tedious.

https://dashboard.lutris.net/#/installers/submissions/21787

The lists are limited to 10 items and that's too little.

Right now it doesn't stand out a lot and can be overlooked:

Example: https://lutris.net/admin/games/installer/12193/change/
https://lutris.net/games/the-awesome-adventures-of-captain-spirit/
https://dashboard.lutris.net/#/installers/submissions

https://feral-wildworks.fandom.com/wiki/Feral is a nice wiki site for games informations, could it be possible to add it in external links choice?

Garbage diffs such this one is unreadable mess and utterly useless to moderators:

Sometimes people submit unnecessary installers with changes that can be done to existing ones like changing wine versions.

I'd like for this to make a comeback so we don't approve dumb installers like that.

I would like to be able to see how many pages of unmoderated installers I have to deal with and browse through them.

More consistent with the website and GUI this way.

Hello,
when I validate a submitted script modification, I have to reject all older submitted script modifications.
Sometimes there are more than 20 modifications to reject, it takes a lot of time and it is useless as we have already validated a script.
What about to automatically reject all all older submitted script versions when a modo validated one of them?

The installer: line is not actually there in the submission at the bottom, but it's shown like it's added there

If I switch sorting preference to "oldest", this sorting rule will reset if I review an installer, close the page or switch to another tab (like new installers). This requires pressing the button after each review which is very inconvenient.

As you can see, the diff does not get displayed.
Also, when I open this submission, I get errors.

TypeError: Cannot read property 'search' of null at https://dashboard.lutris.net/static/js/chunk-8f13.c42fddc3.js:1:489775 at Object.e [as mode] (https://dashboard.lutris.net/static/js/chunk-8f13.c42fddc3.js:1:492568) at a.outputDiff (https://dashboard.lutris.net/static/js/chunk-5fcf.ad336b66.js:1:1569) at a.descriptionDiff (https://dashboard.lutris.net/static/js/chunk-5fcf.ad336b66.js:1:947) at Me.get (https://dashboard.lutris.net/static/js/chunk-libs.3aa58c9a.js:18:15990) at Me.evaluate (https://dashboard.lutris.net/static/js/chunk-libs.3aa58c9a.js:18:17140) at a.descriptionDiff (https://dashboard.lutris.net/static/js/chunk-libs.3aa58c9a.js:18:18982) at a. (https://dashboard.lutris.net/static/js/chunk-5fcf.ad336b66.js:1:3615) at a.t._render (https://dashboard.lutris.net/static/js/chunk-libs.3aa58c9a.js:18:32691) at a.n (https://dashboard.lutris.net/static/js/chunk-libs.3aa58c9a.js:18:60901)

Since there's no way to report this from the website or /admin and strider doesn't always see it in the Discord I figured I'd open this ticket.

Sega Genesis & Mega Drive Classics has the wrong name but I can't change it until the dupe is deleted.

Possible? It's a hassle going back and forth.

People love to submit new installers instead of changing existing ones for no reason, which they then edit, making them end up in the submissions list instead of staying in the "New Installers" section. That should not happen, instead, the edit to the new installer should replace the previous "new installer" submission and stay in the "New Installers" section.

Would be nice to have sorting for that view as well.

Very often the installers that we review can be alright but may contain a tiny mistake or an awful name, which can be easily fixed. But currently, there's no way to do that from the dashboard, you have to look for the game on the website yourself and edit the installer manually which after a few of them makes you go insane.

When reviewing an installer, if you first edit the "notes" field or any other field but "script", and then edit the "script" field, the "script' field will be very small. This hinders the reviewing process.
Observe:

Currently, installer updates are sorted by submission date (most recent first, to form a LIFO queue). However, new installers are sorted alphabetically. Most of the current first page of submissions has something that makes them hard to approve for one reason or another (and I do not want to reject them; see #26), so this view is basically useless at the moment :(

This happens sometimes for whatever reason (the installer on the screenshot if for LoL)? I have no idea how and why.

It's pretty hard to see what was added to the suggested change.

I would to be able to view installers that were the oldest to be submitted instead of newest, and be able to choose between 2 options.

This happens a lot:

1. Installer version X doesn't work
2. Someone forks installer X and submits it as version X (fixed)

Current workaround:

• Accept and publish installer X (fixed)
• Delete installer X
• Rename X (fixed) back to X

This is extra work and means that the history for installer X is lost.

It would be better if I could instead accept the X (fixed) version and then merge it into X. The merging implementation would take these actions:

• Adds the most recent revision of X (fixed) as a revision of X.
• Deletes X (fixed)

I think this happens if you edit the installer in admin menu.

Despite the diff field being large, when i click on "edit", it shrinks to this, making editing feature essentially useless:

Fixed the Toontown installer and noticed only my drafts were deleted.

https://dashboard.lutris.net/#/installers/submissions/23297

https://lutris.net/games/resident-evil-revelations-bio-steam/installer/edit

lutris:resident-evil-revelations-biohazard-revelations-ue?revision=23297

It's kind of pointless to see 10 submissions to the same same installer from the same person, just show me one, the other ones will get cleaned anyway.