lure / autoturnin Goto Github PK

Wow addon.

Lua 100.00%

autoturnin's Introduction

== AutoTurnIn ==
git: https://github.com/lure/AutoTurnIn
http://wow.curseforge.com/addons/autoturnin/
Accepts and turn in quest to NPC. May handle any quests or specified list. 
May turn in quests with rewards and choose most expensive one for future selling.

/au 		- for GUI settings

---------------------------------------------------------------------------------------------------
Usefull staff since I tend to forget it:
---------------------------------------------------------------------------------------------------
to enable taint logging ingame 
	/console taintLog settingg
in config: 
	SET taintLog setting

0 Disables taint logging.
1 Actions blocked due to taint are logged.
2 Enables additional log messages indicating when accesses to tainted global variables occur.
---------------------------------------------------------------------------------------------------
to enable console: add `-console` to game start params 
---------------------------------------------------------------------------------------------------
to export source code: console should be enabled, 
	exportInterfaceFiles code
---------------------------------------------------------------------------------------------------
to export arts: console should be enabled, 
	exportInterfaceFiles art
---------------------------------------------------------------------------------------------------
to dump ingame expressions, instances etc
	/dump ... 
---------------------------------------------------------------------------------------------------
Framestack 	
	/fstack [showhidden]
---------------------------------------------------------------------------------------------------
Expose events 
	/etrace <<command>>

autoturnin's People

Contributors

Stargazers

Watchers

Forkers

katyl torpis tradortiz apokalypsepro lnsoso skadabucci chriskader szjunklol hyphie24

autoturnin's Issues

Compatibility w/ Immersion

On the off-chance that this matters (since it's not really a bug but a different behavior regarding an add-on) I'd like to share that while using Immersion the quests aren't automatically accepted.

I mean... They are (sometimes) but first you have to manually accept one (sometimes multiple).

This wasn't the case with the previous version. I was able to automatically accept all quests without any issues while using Immersion

I should also add that this behavior is not exclusive to AutoTurnIn. Similar add-ons face the same issue.

ISSUE FIXED BY THE LATEST RELEASE - POSTED WITHOUT KNOWING AN UPDATE WAS AVAILABLE - SORRY

Gaining a level causes an on-going LUA error until I reload the UI

on Version 10.0.7, whenever I gain a level, I have to reload the UI due to an error with this addon. Failing to do so will make keyboard interactions ignored by the system, through a LUA error.

Auto equip seems to be broken

Issues with Rinling in darkmoon Faire

Every time i try to get the leatherworking quest from Rinling, it won't let me b/c it automatically gets "He Shoots, He Scores" and every time I click on him afterwards, it immediately closes the window. I have to disable autoturnin and reloadui, do the quest, then enable and reloadui every time.

Error when going into edit mode

If there is a way I can access the error log to provide more details on this error, please let me know how to do so and I will attach it to this issue.

Thanks!

Move the "Ignore this NPC" checkbox

When an NPC has a reputation bar on the GossipFrame, the checkbox is very hard to see and click on.
My suggestion is to move the checkbox and text on top of the GossipFrame, above the NPC name.

IsQuestIgnored() returns nil

Since 7.2 IsQuestIgnored() seems to always return nil and cause an error.

Removing the call to this function from the elseif condition in the function AutoTurnIn:QUEST_DETAIL removes the error aswell. I did not check if this breaks anything else.

Lua error

4x AutoTurnIn\QuestLevel.lua:61: attempt to index local 'questInfo' (a nil value)
[string "@AutoTurnIn\QuestLevel.lua"]:61: in function <AutoTurnIn\QuestLevel.lua:42>
[string "=[C]:"]: in function 'ObjectiveTracker_Update'
[string "@Blizzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua"]:930: in function <...zzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua:833>

Locals:
self = nil
tracker = ObjectiveTrackerFrame {
 0 = <userdata>
 contentsHeight = 0
 blockTemplate = "ObjectiveTrackerBlockTemplate"
 fromModuleOffsetY = -10
 HeaderMenu = <unnamed> {
 }
 fromHeaderOffsetY = -10
 updateReasonEvents = 0
 lineSpacing = 2
 freeLines = <table> {
 }
 freeTimerBars = <table> {
 }
 lineTemplate = "ObjectiveTrackerLineTemplate"
 freeProgressBars = <table> {
 }
 usedTimerBars = <table> {
 }
 isUpdating = false
 hasSkippedBlocks = false
 usedBlocks = <table> {
 }
 oldContentsHeight = 0
 lastMapID = 590
 MODULES = <table> {
 }
 blockType = "Frame"
 blockOffset = <table> {
 }
 BlockDropDown = ObjectiveTrackerBlockDropDown {
 }
 lineWidth = 0
 isUpdateDirty = false
 initialized = true
 contentsAnimHeight = 0
 friendlyName = "DEFAULT_OBJECTIVE_TRACKER_MODULE"
 watchMoneyReasons = 0
 poolCollection = <table> {
 }
 BlocksFrame = ObjectiveTrackerBlocksFrame {
 }
 MODULES_UI_ORDER = <table> {
 }
 usedProgressBars = <table> {
 }
 updateReasonModule = 0
}
(for index) = 5
(for limit) = 7
(for step) = 1
i = 5
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
 ObjectiveTrackerBlockTemplate = <table> {
 }
}
(for control) = "ObjectiveTrackerBlockTemplate"
blockTemplate = "ObjectiveTrackerBlockTemplate"
blockTable = <table> {
 61874 = <unnamed> {
 }
}
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
 61874 = <unnamed> {
 }
}
(for control) = 61874
id = 61874
block = <unnamed> {
 0 = <userdata>
 lines = <table> {
 }
 id = 61874
 module = <table> {
 }
 HeaderButton = ObjectiveTrackerBlocksFrameHeader {
 }
 blockTemplate = "ObjectiveTrackerBlockTemplate"
 HeaderText = <unnamed> {
 }
 nextBlock = <unnamed> {
 }
 height = 12.034206
 used = true
}
questLogIndex = 4
questInfo = nil
(*temporary) = nil
(*temporary) = 4
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'questInfo' (a nil value)"

Interop with external ACE3

Hey,
i've got something weird, when the ACE3 is used from another addon

AutoTurnIn (ATI) Version 10.3.1

22x AutoTurnIn/AutoTurnIn.lua:420: hooksecurefunc(): ObjectiveTracker_Update is not a function
[string "=[C]"]: in function `hooksecurefunc'
[string "@AutoTurnIn/AutoTurnIn.lua"]:420: in function <AutoTurnIn/AutoTurnIn.lua:404>
[string "=[C]"]: ?
[string "@ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0-13.lua"]:66: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:61>
[string "@ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0-13.lua"]:494: in function `InitializeAddon'
[string "@ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0-13.lua"]:619: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:611>

If i rename "AutoTurnIn" to "1AutoTurnIn" to use the delivered ACE3, this issue does not popup.

I've checked the delivered ACE3's, and they are both on 3.0-13 and identical. I also copied the ATI Version to Ark and the issue persist. So its maybe just a "path" thing, that the reference does not match

Lua error and maybe wrong Ace3 lib choosen

What version number you are using?
10.0.1

What game client are you playing? Retail, Burning Crusade, Classic / Live, PTR, Beta
Retail 10.0.0.46313

What language is the game client set to?
German

Describe the bug
A clear and concise description of what the bug is.

On log in an lua error occurs (see below in "Additional context"). It looks like that AutoTurnIn takes the library from the first folder it founds inside the "AddOns" folder. Is AutoTurnIn using an old version of Ace3?

To Reproduce
Steps to reproduce the behaviour, if possible:

It is also reproduceable if you install "Ace3" as dedicated addon.

Additional context
Add any other context about the problem here.

Message: Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:94: attempt to call method 'LibDataStructure' (a nil value)
Time: Thu Oct 27 14:32:37 2022
Count: 1
Stack: Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:94: attempt to call method 'LibDataStructure' (a nil value)
[string "@Interface/AddOns/AutoTurnIn/AutoTurnIn.lua"]:94: in function <Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:63>
[string "=[C]"]: ?
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:66: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:626: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:611>
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11090: in function `LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11106: in function `BlizzardAPIHook'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:2886: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:2855>
[string "=[C]"]: ?
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:66: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:626: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:611>

Locals: <none>

** Alternative lua error with "Ace3" installed **

Message: Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:94: attempt to call method 'LibDataStructure' (a nil value)
Time: Thu Oct 27 14:46:17 2022
Count: 1
Stack: Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:94: attempt to call method 'LibDataStructure' (a nil value)
[string "@Interface/AddOns/AutoTurnIn/AutoTurnIn.lua"]:94: in function <Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:63>
[string "=[C]"]: ?
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:66: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:626: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:611>
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11090: in function `LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11106: in function `BlizzardAPIHook'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:2886: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:2855>
[string "=[C]"]: ?
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:66: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:626: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:611>

Locals: <none>

https://github.com/lure/AutoTurnIn/blob/master/AutoTurnIn.lua#L94

FR: Automatic choose of Quest Dialogs / German Translation

Hi, what do you think about the feature that ATI automatically choose the right dialog from the quest-npc if it's needed? Like the picture below:

And I've optimized the german language file for the german-spelling. Do you need this? Should I make a PR? :-)

Text misalignement on the Quest Window when AutoTurnIn and ElvUI are activated

Hi.

I noticed a small "quest objectives text misalignement" on the Quest window when both ElVUI 12.24 and AutoTurnIn 9.0.2 are activated.

Here is the default Blizzard Quest Window, with all addons disabled (as you can see, there's no problem):

Note that this default Quest Window looks the same when only AutoTurnIn 9.0.2 is enabled (all quests objectives look fine, the quest window looks the same as the above screenshot).

Here is the Quest Window when only ElvUI 12.24 is enabled (no misalignement, quests objectives look fine):

But when both ElvUI 12.24 and AutoTurnIn 9.0.2 are activated, here is how the Quest Window looks like:

World of Warcraft Shawdowlands version 9.0.5.38134
French locale (it may also happen with other languages, I don't know)
Windows 10 64bits, nvidia GTX 1070 (drivers: 465.89)

Possible to add Darkmoon Faire Dialog?

I'd like to be able to run past Sayge and quickly select the dialog choices that give me +% damage. I think most players would prefer damage, and obviously if it's optional then those players/classes could have it switched off so they can make a manual choice.

Would that be possible to add?