luox-app / luox Goto Github PK

Hello, thanks for creating this awesome application. I was going through the test CSV example, and I think there is a potential bug or annoying situation.

Steps to reproduce
In "Step 2. Tell us more about your data" -- try to change the measurements label value (CSV column).

Expected result
The calculation is triggered after I have changed the label name (i.e., when the measurement textbox is out of focus)

Actual result
The calculation is triggered after every keypress event.

It is a bit annoying, so I thought I should point it out.

• Light safety calculations
• Wavelength sampling
• Standard ways of specifying units
• Remote API
• Optional visualisation of spectral sensitivity
• Overlay explainers

In #99, @NilesDavis provided a patch to update the D50 illuminant data from ISO/CIE 11664-2:2020 in rc/data/reference_spectra.json. However, the About page hasn't been update. @NilesDavis: Could you please send over the full reference as in the table above (with page numbers and table number)?

Thanks!

explore.html and upload-csv.html currently do the correction of power and area units in the wrong direction. The values given in the lines below (around lines 40ish in the files) should be 1/x instead of x.

                  <select class="form-control" id="power-units">
                    <option value="1000000">µW</option>
                    <option value="1000">mW</option>
                    <option value="1" selected>W</option>
                  </select>
                  per
                  <select class="form-control" id="area-units">
                    <option value="1000000">mm²</option>
                    <option value="10000">cm²</option>
                    <option value="1" selected>m²</option>
                  </select>

Hi,
I came across your project via a LinkedIn daylighting page. I confess I don't know a great deal about the biological side of your area of research, however I was wondering if there is any interest in your field in the spectral qualities of light transmitted by building windows?

I used to work at Lawrence Berkeley National Lab and helped to develop the optical calculation code behind the software tool 'Optics' which calculates the (spectral) optical properties of various combinations of window glass from a large international database of glazing product properties. This software is very old now but is still in wide use and the database is continually updated. LBNL are working on a new generation of software which will eventually replace the functionality of Optics. One key part of this is moving the database of glazing product optical properties online and releasing an open source calculation engine that can be used to calculate the optical (and thermal) properties of combinations of products. The main application of this software is building energy modelling, but the underlying data is also used for daylighting modelling.

I am an independent consultant these days, not associated with LBNL, but I still have an active interest in this area. I think it would be pretty straightforward to use Optics (or the development version of the newer generation of tools) and a few spreadsheet calculations to generate input spectra for luox. The calculation would require an input solar spectrum and Optics can supply the spectral transmittance of the glazing at normal incidence. If there's any interest I would be very happy to contribute a tutorial on how to use Optics to support the calculation of input spectra.

best regards,
Rebecca Powles

Just noting this down here. Currently, calculateEquivalentDaylightAlphaOpic uses predefined values up to 4 decimal points, thereby losing some precision. It would be better to calculate the values on the fly, and use these, as this would explain small discrepancies with the current CIE toolbox.

I found that in the dataset for standard illuminants (reference_spectra.json) that 2 datasets are taken from other sources. So C, D50, D55 and D75 are taken from the CIE 015:2018 as they are in 5nm resolution as given in the standard. Standard illuminants A and D65 are in 1nm and exactly match the dataset from the ISO/CIE 11664-2:2020. What is the reason for this? Shouldn't the 5nm CIE15 data be the reference for all standard illuminants?

Hi!
First at all: thank you for all the work you did! It is great to finally have some persons publishing light computations open source. This is what I was longing for since 2008, but I did not find any acceptance for it.
I know it is a little nerdy, but I compared my implementation with yours and found 3 values in your dataset differing from those, given in the standard CIE S 026:2018. That are 3 values in the L-cone action spectrum at 661, 662 and 663nm each differing +1E-7
Can you confirm this?
Hopefully I can contribute more. Still digging in the code ;)

Just adding the about page as markdown here so that I can review it within GitHub as rendered as well.

About

Purpose

The goal of this platform to provide user-friendly access to the calculation of quantities related to light and lighting.

How to cite this platform

Spitschan M, Stefani O, Blattner P, Gronfier C, Lockley SW, Lucas RJ. How to report Light exposure in human chronobiology and sleep research experiments. Clocks & Sleep. 2019; 1(3):280-289. DOI: 10.3390/clockssleep1030024.

Developers

This platform was developed by Dr Manuel Spitschan (Department of Experimental Psychology, Unversity of Oxford) and Go Free Range.

Contact

For any questions or concerns, please email Dr Manuel Spitschan ([email protected]).

Funding

Funding to develop luox was provided by:

• Wellcome Trust (Research Enrichment – Open Research, 204686/Z/16/C);
• Society of Light & Lighting (2020 Jean Heap Bursary);
• van Houten Fund of the University of Oxford (VH-148).

During development of the platform, Dr Manuel Spitschan was supported by a Sir Henry Wellcome Postdoctoral Fellowship (Wellcome Trust, 204686/Z/16/Z) and Linacre College, University of Oxford (Biomedical Sciences Junior Research Fellowship).

Acknowledgements

The following individuals tested and provided feedback onan early version of the platform: Paul O'Mahoney, Tos Berendschot, Isabel Schöllhorn, Christine Blume, Katharina Wulff, Kinjiro Amano, Tony Esposito, Minchen Tommy Wei, Suzanne Ftouni, Paula M. Esquivias, Gayline Manalang Jr., Daniel Garside, Joachim Stormly Hansen, and Hao Xie.

Precision and decimal points

Sources of effect function

Sources of illuminant data

References to official documents

• CIE 013.3-1995: Method of measuring and specifying colour rendering properties of light sources
• CIE 224:2017: CIE 2017 Colour Fidelity Index for accurate scientific use
• CIE 015:2018: Colorimetry, 4th Edition, DOI: 10.25039/TR.015.2018
• EN ISO/CIE 11664 2:2011
• CIE S 026/E:2018: CIE System for Metrology of Optical Radiation for ipRGC-Influenced Responses to Light, DOI: 10.25039/S026.2018

UCUM is a standardised scheme for units: https://ucum.nlm.nih.gov/ucum-service.html / https://ucum.org/trac
We should include units using this system.

GitHub recently announced that they now have support for the human- and machine-readable Citation File Format. I thought you might be interested in creating a CITATION.cff file for the repo.

On some systems and browsers, it looks like certain characters are not properly rendered, yielding results like:

[W ⋅ m⁻² ⋅ nm⁻¹]

This is probably due to things like • and –. happy to go with whatever the easiest way to fix this is.