Urllib3 dependency in tts.py about chinese-support-redux

[luoliyan]

Okay, I'm just going to bundle everything.

[luoliyan]

That will only work if you have the modules installed on your system. Bundling just means I'll package them up with the add-on so there's no outside dependency.

[luoliyan]

Thanks for your help with this one. The updated __init__.py got lost in a different branch. I've tested on Windows. It should work now.

[luoliyan]

Hmmm, are you sure? urllib3 is a dependency of requests which is bundled with Anki. Are you on Windows? Can you do this for me:

1. Open Anki with addons disabled (hold down Shift while it's starting)
2. Open the console (Ctrl+Shift+;)
3. Paste this in the top box :

for top in sorted(set([m.split('.')[0] for m in modules])):
    print(top)

4. Press Ctrl+Enter
5. Post the list of modules here for me

[3ter]

Yes, I am on Windows. And I just read about the REPL in Anki on the addon dev page because I was curious 😄.

>>> for top in sorted(set([m.split('.')[0] for m in modules])):
...     print(top)
Traceback (most recent call last):
  File "aqt\main.py", line 1174, in onDebugRet
  File "<string>", line 1, in <module>
NameError: name 'modules' is not defined

[luoliyan]

Sorry, I'm having a sloppy day. It needs to be:

from sys import modules
for top in sorted(set([m.split('.')[0] for m in modules])):
    print(top)

[3ter]

I can see only urllib no urllib3.

PyQt5
__future__
__main__
_ast
_bisect
_blake2
_bootlocale
_bz2
_codecs
_collections
_collections_abc
_compat_pickle
_compression
_ctypes
_datetime
_elementtree
_frozen_importlib
_frozen_importlib_external
_functools
_hashlib
_heapq
_imp
_io
_json
_locale
_lzma
_markupbase
_opcode
_operator
_pickle
_portaudio
_random
_sha3
_signal
_socket
_sqlite3
_sre
_ssl
_stat
_string
_struct
_thread
_warnings
_weakref
_weakrefset
_winapi
abc
anki
aqt
argparse
ast
atexit
audioop
base64
binascii
bisect
bs4
builtins
bz2
calendar
cgi
chunk
codecs
collections
contextlib
copy
copyreg
ctypes
datetime
decorator
difflib
dis
distutils
email
encodings
enum
errno
faulthandler
fnmatch
functools
gc
genericpath
getpass
gettext
gzip
hashlib
heapq
hmac
html
http
imp
importlib
inspect
io
ipaddress
itertools
json
keyword
linecache
locale
logging
lzma
markdown
marshal
math
mimetypes
msvcrt
netrc
nt
ntpath
nturl2path
opcode
operator
optparse
os
pickle
platform
posixpath
pprint
pyaudio
pyexpat
pyimod01_os_path
pyimod02_archive
pyimod03_importers
pythoncom
pywintypes
queue
quopri
random
re
reprlib
requests
select
selectors
send2trash
shlex
shutil
signal
sip
socket
socketserver
sqlite3
sre_compile
sre_constants
sre_parse
ssl
stat
string
stringprep
struct
subprocess
sys
tempfile
textwrap
threading
time
token
tokenize
traceback
types
unicodedata
urllib
uu
uuid
warnings
wave
weakref
win32api
win32com
win32file
win32pipe
winerror
winreg
xml
zipfile
zipimport
zlib

[3ter]

Okay, I'm just going to bundle everything.

Is bundling as easy as changing the import statements as described here on reddit?

[luoliyan]

Are you able to give the update a try? Download https://ufile.io/b89ef, make a new folder in your addons21folder and drop all the files in there

[3ter]

I'm getting the same error.

[3ter]

@luoliyan Shouldn't there be a file called urllib3.py in the folder? I couldn't find one. In the six module folder we have a file six.py as well and this can be imported.

[luoliyan]

Im pretty sure I set up the import path correctly in `__init__.py`. Python should know to look in the `src` folder. Have you deleted the old Chinese Support folder? My only guess is Anki is trying to import the old one first. I'm away from home for the day, but I'll set up a Windows computer to test with when I get back.

[3ter]

Just wanted to leave another "Thank you!" here 😄.