lunarmodules / say Goto Github PK

Hello,

On https://luarocks.org/modules/olivine-labs/say
homepage is set to http://olivinelabs.com/busted/
it should probably be https://github.com/Olivine-Labs/say instead

Kind regards

based on PR #17 a new release was tagged, and is visisble in releases tab. But wasn't uploaded to luarocks.

Hello !

(Currently packaging for Debian a few of your libraries leading up to busted !). I've encountered a little issue when testing the installed package. The example in the README.md for say doesn't work (Tested with lua 5.1 and 5.2):

lua5.1: /usr/share/lua/5.1/say/init.lua:44: bad argument #1 to 'ipairs' (table expected, got number)
stack traceback:
    [C]: in function 'ipairs'
    /usr/share/lua/5.1/say/init.lua:44: in function 's'
    z.lua:8: in main chunk
    [C]: ?

Changing

print(s('money', 1000)) -- I have 1000 dollars

to

print(s('money', {1000})) -- I have 1000 dollars

in README.md makes it work. Should this be fixed in the readme or in the library so that it builds a one element table if passed a string/number ?

Cheers

Why "s.lua", and not "say.lua" or "init.lua".
the former requires; local s = require("say.s")
while the latter can be simply; local s = require("say"), far more intuitive?

Hi!
the persistence embed function are a good feature - aka gnu gettext - to load/save.

Thanks