Comments (5)
@scottaohara thank you! Will merge it then :)
from starability.
Hi @scottaohara I just took a look at that and I believe that it is impossible to replace the background with a unicode character in the current setup: starability is using image sprites for that and a pretty neat hack to enable hovering the stars. Rewriting it with svg could indeed break some of the animations.
How about we remove the styling in case someone is using a high contrast mode? Then these are just regular radio buttons that are accessible?
from starability.
Yeh, that makes sense. I had to fiddle with it quite a bit to get the stars to show up with CSS content.
But yeh, I think just falling back to regular radio buttons is a great idea. :)
from starability.
Can you take a look at the PR @scottaohara? I only found info on how to make a query for Windows support. Is there any other way I could support this for MacOS? Or it is known that it is better to use Windows if one has a need for high contrast mode? #33
from starability.
Gave the branch a quick test on my PC and the radio buttons are visible.
Right now high contrast mode is a windows thing that IE, Edge, and mostly-firefox support.
Apple has things like inverted colors and such, but that doesn't remove background images like high contrast mode does. So this should be a-ok for macs still.
from starability.
Related Issues (20)
- Rating starts with yellow stars instead of grey stars HOT 6
- Invisible input creates accessibility issue HOT 2
- Touch gesture support HOT 3
- Support for half stars HOT 6
- Star size HOT 3
- Focus ring is not demonstrated in example HTML HOT 1
- Better support for `disabled` attribute. HOT 3
- Regarding stability star 10 rating HOT 2
- On Mac voice over, it announces you are currently on radio button, X of 6. HOT 3
- Node throws SyntaxError: Unexpected token '.' for npm package css HOT 1
- Change size of stars? HOT 2
- ItΒ΄s possible to select half stars? HOT 1
- Problem when decreasing the size HOT 1
- Spacing between the stars
- Dosn't work in 2021? HOT 3
- Can't print the stars in page HOT 1
- fixing required in starability-heartbeat.css
- Multiple ratings on same page HOT 1
- Responsive Star Size HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starability.