lullabot / custom_layouts

Drupal 8 layouts with configurable classes and titles, code to massage Layout Builder block list categories and titles.

Custom layouts for Layout Builder

Adds custom layouts to Layout Builder, which contain options to add css classes and titles to each section.

• Several custom layouts are provided here, which can be further adjusted in the theme.
• Css classes are managed via a vocabulary. There is one vocabulary for general css and another for css to use on titles.
• We use Chosen to make the class selection super easy. That adds tags-style functionality to the simple selector.
• The code massages the Layout Builder block list to change some category names and block titles so they make more sense in Layout Builder.

Configuration

• Navigate to admin > extend and enable the module.
• The code assumes that vocabularies called classes and title_classes already exist.
• The code assumes a field called field_class is used on these vocabularies to store the actual classes.
• The actual class(es) are stored in a field on the term, which means any descriptive title can be used for the name of the class or class collection.

Composer

To include this module in a composer project, add the following to the 'repositories' section of the top level composer.json file:

        "lullabot/custom_layouts": {
            "type": "vcs",
            "url": "https://github.com/lullabot/custom_layouts.git",
            "no-api": true
        }

Then type the following on the command line:

composer require lullabot/custom_layouts

custom_layouts's Issues

When using a section title, it goes before regions and then the columns or regions don't display properly

When using a section title, it goes before regions and then the columns or regions don't display properly.
For instance, if you add a section with 2 columns, and you name that section, the title goes to the left of the 2 columns, and then it shows
[title] [column one]
[column two on its own line]

Rather than:
[title]
[column one][column two on same line]

Is this correct behavior? It requires fixing with css for every time a section title is used, which seems to mean that none of the section layouts will work as described IF you use a section title, unless you fix it with css.
I think that the section title should have it's own space at the top/above the section regions so that the layout selected is displayed properly.
Perhaps I misunderstand how this section title can be used.

Couldn't install following the ReadMe

About a month ago I tried out this module and had some difficulties. This is just an issue in case you want to fix the READMe process. Following the README process, I couldn't get this module to work. I had to add this module as a custom module in modules/custom as a git sumodule.

The instruction to add lullabot/custom_layouts..... lines however it was into the package.json file and then do the composer require... line would never actually install the module or do anything that I could see. The module worked fine once I added it via git as a git submodule or just via git clone in modules/custom.

Issues don't seem to be addresses but here is feedback anyway - composer.json error

I tried to edit my composer.json according to the instructions with and without a comma and they both fail when running the composer command

"repositories": [
    {
        "type": "composer",
        "url": "https://packages.drupal.org/8"
    } ,
    "lullabot/custom_layouts": {
        "type": "vcs",
        "url": "https://github.com/lullabot/custom_layouts.git",
        "no-api": true
    }
],

With the comma I get
[Seld\JsonLint\ParsingException] "./composer.json" does not contain valid JSON Parse error on line 15: ..." } "lullabot/custom_lay... --------------------^ Expected one of: 'EOF', '}', ',', ']'

Without the comma I get
[Seld\JsonLint\ParsingException] "./composer.json" does not contain valid JSON Parse error on line 16: ...abot/custom_layouts": { "typ ----------------------^ Expected one of: 'EOF', '}', ',', ']'

Incorrect template being used

If you use the layout 'layout_onecol_100' within layout builder for a section, the template that is used is the one from layout_discovery.

This seems to be because the definition of the layout includes

path: layouts/onecol 
template: layout--onecol

which is the exact same for the layout discovery. Once I've renamed the template and updated the layout definition in custom_layouts.layouts.yml, it started to work as expected.

Is this some kind of scoping / override not being picked up issue?

Add to the documentation not to use with layout discovery overrides module

Add clarification that this module is SIMILAR to the layout discover overrides module, but they shouldn't be used together. They both do the same thing.
https://www.drupal.org/project/layout_discovery_override