lukecarr / nightly-check

🌓 GitHub action that checks for changes between nightly CI jobs

👋 Hi there!

I'm a 22 y/o from the UK, currently working as a Software Developer at Met Office.

As far as open-source projects go, I enjoy working on anything and everything related to game development 🎮 (see Subtale), privacy 👀, and data analysis/engineering 🗃️.

I currently spend most of my time in Rust and TypeScript, and I take pride in writing code that's lightweight 💡 and performant 💪!

My GitHub

📊 Profile Stats

🗣️ Languages

🔥 Current Streak

📌 Holopin Badges

nightly-check's Issues

default value for within variable is not working

I tried to use your action but it is not working as intended. This is the relevant part of my own action:

jobs:
  check:
    runs-on: ubuntu-latest
    outputs:
      changes: ${{ steps.nightly-check.outputs.changes }}
    steps:
      - id: nightly-check
        name: Check for changes since last nightly
        uses: lukecarr/[email protected]

As you can see, I don't have within specified, so it should use your default value. But the variable is empty as you can see in the output of your action (see empty after value):

test -z $(git rev-list --after="" abd68737727b4f5624c055f5c47be1206e89dc99) && echo "changes=true" >> $GITHUB_OUTPUT

Then I tried to specify the within value in my action. Same problem, the variable is still empty.

Support configurable "within" durations

The action checks for changes in the Git tree within the last 24 hours.

This hardcoded value should be replaced with an action input that allows for customisation.

The action input should retain the existing "24 hours" behaviour as a default value to prevent introducing a breaking change.

Replace deprecated `set-output` command

GitHub is deprecating the set-output command currently utilised by this action:

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Following the guidance in the linked migration guide, we should instead echo the output to the $GITHUB_OUTPUT environment file.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

github-actions

action.yml

• actions/checkout v4

---

• Check this box to trigger a request for Renovate to run again on this repository