lukebayes / laml Goto Github PK

Update custom assertions so that they do not call panic directly.

These should return or trigger a test failure.

If it's what is required, we can pass the testing.T reference into these assertions and simply call t.Error or t.Errorf.

Neither of these are returning reliable results.

I'm pretty sure I've done something dumb related to pointers, but not sure exactly what it is.

I'd really like to keep the semantics as they make tests much easier to read and write.

Investigate and decide what to do.