Coder Social home page Coder Social logo

abb-speedtest-cli's People

Contributors

borhub avatar dependabot[bot] avatar lukealford avatar raymoz101 avatar tjc avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar

Forkers

gittastic borhub tjc raymoz101 poweredbysugar

abb-speedtest-cli's Issues

JSON output is... not JSON

Running the program with --json produces output that is similar to JSON, but is not valid JSON, and not parsed by JSON libraries.
For example:

results: {
  location: 'Melbourne',
  ping: '8',
  jitter: '2',
  download: '108.4',
  upload: '21.4',
  date: '8/30/2020 12:26:30 pm'
}

That won't parse in either the command-line jq utility, nor Ruby or Scala's JSON parsers...

Can I suggest aiming for a format more like this?

{ "location": "Melbourne", "ping": 8, "jitter": 2, "download": 108.4, "upload": 21.4, "date": "2020-08-30T00:26:30" }

That will enable the output to be parsed by common JSON libraries, or imported into databases and spreadsheets easily.

save option doesn't work

It's constructing paths with '\' instead of '/'. Overriding the output destination doesn't help.

$ abb-speedtest --location Melbourne --csv --save
{ Error: EACCES: permission denied, mkdir '/home/evan\Documents\abb-speedtests'
    at Object.fs.mkdirSync (fs.js:885:18)
    at checkFolder (/usr/local/lib/node_modules/abb-speedtest-cli/cli.js:63:8)
    at Command.<anonymous> (/usr/local/lib/node_modules/abb-speedtest-cli/cli.js:26:11)
    at Command.listener (/usr/local/lib/node_modules/abb-speedtest-cli/node_modules/commander/index.js:315:8)
    at emitNone (events.js:106:13)
    at Command.emit (events.js:208:7)
    at Command.parseArgs (/usr/local/lib/node_modules/abb-speedtest-cli/node_modules/commander/index.js:665:12)
    at Command.parse (/usr/local/lib/node_modules/abb-speedtest-cli/node_modules/commander/index.js:474:21)
    at Object.<anonymous> (/usr/local/lib/node_modules/abb-speedtest-cli/cli.js:58:9)
    at Module._compile (module.js:652:30)
  errno: -13,
  code: 'EACCES',
  syscall: 'mkdir',
  path: '/home/evan\\Documents\\abb-speedtests' }

Not recording results on my.aussiebroadband.com.au

After a bit of debugging, I've noticed it's no longer recording the result on my.aussiebroadband.com.au for me. Need to figure out why this is the case, the tool waits for all XHR Requests to complete but still fails to make it to the website

I've tried extending the XHR wait times and also making sure a valid agent header is set still no change. Needs further debugging.

Docker - Scheduled task? Export to InfluxDB?

Any plans to add scheduling in, something that can be run in the event you're doing fault-finding with AussieBB?

Would it be possible to have the results added to a grafana/chronograf-friendly DB format, like InfluxDB?

Using deprecated packages

Just installed abb-speedtest-cli and got the following warnings:

npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)

Is it possible to update abb-speedtest-cli to use more recent packages?

"Quiet mode" has misleading description

The --quiet mode is described as:

.option('-q, --quiet [optional]', 'disables result reporting to ABB')

However the actual effect in the code seems to be mixed -- it also reduces the verbosity of console log output (see #11 )

Could I suggest using two flags, perhaps?
Maybe --quiet to reduce the console status output down to just the data, and --no-report to disable the reporting back to ABB?

cc @ChrisRiddell @borhub

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.