luigi1111 / xmr.llcoins.net Goto Github PK

When testing another CryptoNote based coin on addresstests.html, it would appear that the private view key is not generating correctly based upon a given seed (using button Gen 3&4). The CN coin in question has no revisions to the algorithm for address generation. Network byte is fb01 (CryptoNoteConfig.h specifies 0xfb, following the example for AEON we appended 01). A standard 64 length simplewallet-compatible hexadecimal seed is used.

Seed/Private spend key: B42F140750B202D89EFB367B666C6F12B2721C5CDF895AA0431BD5B6E71FF401

Expected private view key: A90432FBD1FE7636639E876C4A96ABDDAFAE6360D58292F5690D58A969BB9C0A
Actual generated private view key: b82659b12c9f36cb28a2f07613e6851ec740abf82952fabdba37f42930d9950e

Public keys are generating properly.
Public view key: 025677374b0f05b75a6f8468d91bc53ab34b05611849e06d109b15ad72b68ac5
Public spend key: b00703d3a6723b4e4fae7bd2807baf02fde92d6a4744e2dea718298e9934bf68

If the private view key is wrong, this also of course leads to the address being generated incorrectly after the first 46 characters:

Expected address:
iz5YdZVeyM3AvLoyuDiprWWGqHqY3kE6PewvQ2ihBKhmZ1t5oDSjv7Y1xTN3JFvjZkZzNXtu9nnmveYDPmJKJdAu2C74LLKRB

Actual generated address (using incorrectly generated PVK):
iz5YdZVeyM3AvLoyuDiprWWGqHqY3kE6PewvQ2ihBKhmZ1uentCDiP1E6E2r3adFJb3YLxXWszd8jKFxqFjBkoST2eFf3rWd1

https://github.com/luigi1111/xmr.llcoins.net/blob/master/site/js/crypto.js

In the crypto.js file, the _free function is not implemented. Right?

It seems this causes a bug:

function sc_reduce32(hex) {
    var input = hextobin(hex);
    if (input?.length !== 32) {
        throw "Invalid input length";
    }
    // Module._malloc() return the address of the alloced memory - the pointer
    var mem = Module._malloc(32);
    Module.HEAPU8.set(input, mem);
    Module.ccall('sc_reduce32', 'void', ['number'], [mem]);
    var output = Module.HEAPU8.subarray(mem, mem + 32);
    Module._free(mem);
    return bintohex(output);
};

In the above snippet of code, since the memory is not actually freed, so if you run this function, say 10k times, then the crypto.js will throw an error:

Cannot enlarge memory arrays. Either (1) compile with -s TOTAL_MEMORY=X with X higher than the current value 16777216, (2) compile with ALLOW_MEMORY_GROWTH which adjusts the size at runtime but prevents some optimizations, or (3) set Module.TOTAL_MEMORY before the program runs.

Hi,

Please add function for creating view_tag manually.

Something like keccak_256....

Thank you.

There is a disclaimer at the top of the page saying this is only safe to use on Monero mnemonic strings, and it is great for that. Are you aware of a similar tool for Ethereum?

The certificate on https://xmr.llcoins.net/ expired the 31 march 2024.

Similar to the GPG key and .html.asc signature file of MoneroMooo at MoneroAddress.org. For cold storage on an offline liveUSB, it would be great to verify the download.

I just found your Github, and am excited to use your slowhash.html, sign.html, and addresstests.html files, but I don't really understand what they do :). I've been using the address generator and checktx tools for a while. They are great.

Anyway you can create a Readme for the cryptographic 2nd graders like myself?

Hey great work on xmr.llcoins.net, I've been playing with it the past few days. Been trying to add support for other cryptonote based coins.

How can I add the right prefixes for my custom coins. Right now the private spend and view keys checkout. But the public address keeps using XMR's prefix. How can I change this.

Thanks.

Hello.

I wanted to learn how to use spend key with your project. I pasted txid, private spend key and my public address to your checktx and I got this error:
"Failed to get transaction data! Perhaps MoneroBlocks is down?"

Tried both your online version and offline one downloaded from here.
MoneroBlocks is and wasn't down.

Any idea what might be the cause? I tried it without any proxy or VPN and I got txid, key and address from official Monero full node wallet v0.11.1.0.
Dunno what else I can tell you without my data.

The SHA-256 for the site.zip file here: https://xmr.llcoins.net/ does not match the computed one:
C38FDC81C910DC849482BEE78BA4847222EEBF7ADB0BB63DF1FBA4FBB3A2721B

So either the info you have listed on the website is out of date, or you've been hacked.