lucasaba / gitlabtimetrack Goto Github PK

A better organizzation would be to autowire client inside the gitlab service.

It would aslo useful to differentiate projects and issue call

Ref: https://github.com/8p/EightPointsGuzzleBundle/blob/master/src/Resources/doc/autowiring-clients.md

When checking if an issue has been updated, I only check seconds:

$lastUpdated->diff($newIssue->getUpdatedAt())->s > 2

with the wrong assumption that the value would be the total seconds. But that's not the case!

Would be better to have a page with the list of all gitlab projects from wich to pick or discard the projects to be monitored.

Estimeted -> Estimated

If, for some reason, the gitlab server is not reacheable, there should be a fancy error page not a crash...

show me what this can do before I have to spend hours on installing it please ;)

Hi,

Thanks for the project!

Out of the box, I faced this issue:

request.CRITICAL: Uncaught PHP Exception GuzzleHttp\Exception\ClientException: "Client error: `GET https://gitlab/api/projects?page=1&per_page=100` resulted in a `404 Not Found` response" 

The URL is missing the /. Adding a trailing slash at the end of it in the docker compose fixed it:

GITLAB_SERVER_URL: https://gitlab.com/api/v4

modified to

GITLAB_SERVER_URL: https://gitlab.com/api/v4/

Maybe Guzzle changed and caused this

The console command havn't been updated and setting GitlabRequestService private hides it to the commands.

Please use docker so that I don't have to install all dependencies. For non PHP developers, it will be a great boon.

The installation explained in the README is...not correct.

The licence is completely missing.

I've imported a GitLab project and clicked the "update" button to update the times.
I haven't set an estimate for each task, which probably is why I get the exception:

An exception has been thrown during the rendering of a template ("Warning: Division by zero").

in app\Resources\views\default\view_project_issues.html.twig (line 22)
{% set completition_percentage = (issue.totalTimeSpent/issue.timeEstimate)*100 %}

Need to refactor Gitlab API request

I had to deifne the gitlab request service, like in prev 3.3 version, as public:

gitlabtimetrack.request_service:
        class: AppBundle\Service\GitlabRequestService
        arguments: [ '@eight_points_guzzle.client.api_gitlab', '@monolog.logger' ]
        public: true

While it should use the new service definition:
https://symfony.com/doc/current/service_container/autowiring.html

I think it would be nice if you could see how long each participant spent on a task or on the whole project.
GitLab API does not provide that information with their time tracking functionality - but time operations leave a note (Note API) in the task, which can be processed to find out how much time a user has spent.

I already did something there - but it's rather "hacky" than good style ^^

Add the possibility to save the list of issues in a pdf file

Updating the list of issues can be...time consuming.
It would be better to have an async update of the issues.

When selecting a project to monitor, it would be usefull tho show the full path of the project.

So, insted of MyProject, you should see mypersona/MyProject

When viewing the project's issues would be better to express the time in a human readble format like 47d 4h 27m

Lets use some glitter like in https://adminlte.io/themes/AdminLTE/index2.html !