lucarda / pd-hidraw Goto Github PK

reported issue on https://lists.puredata.info/pipermail/pd-list/2024-04/133146.html

(Note: This is not a bug nor a feature request, just a suggestion to maybe make updating the codebase easier in the future.)

I noticed you manually copied over some files and directories from https://github.com/libusb/hidapi into the hidapi subdirectory of your repo and documented the commit hash at the time of copying. This is all fine, I understand that you probably don't want to clutter your repo with all of hidapi etc.

However, once you want to update hidapi, you will need to redo the manual selection and copying process. It might be easier to declare hidapi a Git Submodule of your repo so that it is automatically included from the original repo at the speficified version / commit hash.

If you want to know more about the Git Submodule approach, check this example and the Git docs. I can also send you a PR with the required change. Just let me know.

If not, feel free to close the issue -- things are fine the way they are :-)

@Spacechild1 when you have time can you review:

Does this output need to be in a clock ?