loyieking / smalise Goto Github PK

It may be overkill at the moment but is this a sane feature-request/idea for this plugin?
Ref: https://github.com/JesusFreke/smalidea

Go To/Peek Definition or Go To/Peek References
These two functions are often used ；But the display results are very very slow or even not displayed！
I‘ve set "smalise.cache.memoryLimit": 2048
Is this a VSCODE's problem Or Smalise’s Bug？

Code auto-completion for smali will be super cool to see. If not for the class names, starting with the bytecodes will be very useful.
About snippets, I imagine something like a method stub, or if-eqz v_, :_ kind of replaceable snippet will come handy while editing large amount of smali.

In a project of mine I came across these two lines of smali code:

    new-instance v1, Lpkg/-$$Lambda$MainActivity$wqafgufGsPnnOcBuIzzHVhnovxo;
    invoke-direct {v1, p0}, Lpkg/-$$Lambda$MainActivity$wqafgufGsPnnOcBuIzzHVhnovxo;-><init>(Lpkg/MainActivity;)V

Which were highlighted like this:

I assume this is because of the "-" prefix as without them syntax highlighting works:

Could this be implemented so we can ctrl+click on a register and go to its first assignment or peek usage like a label?

Edit: What JEB does is that it highlights all the instances of that register in a method if you click on one of them. I think that's also a neat way.

Labels(:cond_1) inside the methods are not ctrl+click -able. Is this intended or just not implemented yet?

The regex.String /(".*?")/ in parser.js shouldn't be lazy as it won't catch escaped double quotes \".

Code doesn't really give any useful error message as to why it is incompatible, but it fails to install. When trying to install this plugin through the store, it says:

When trying to install this plugin manually, it says:

https://git.sr.ht/~yotam/tree-sitter-smali/

Probably can be integrated for faster syntax highlighting.

First of all thanks for this nice extension. I'm planning to write writing an extension to automate apk reversing workflow with apktool, apksigner, jadx, etc. also because I found this extension for vs code :)

About the issue, res IDs in android are in decimal when decompiled to Java with tools like jadx. Each time I want to follow a res ID, I have to do printf '%d' 0x23 thing in a terminal or open calculator. JEB decompiler has this cool feature where you click on a HEX value and press B so you can cycle through DEC-OCT-HEX radix values which makes it super easy to work with the IDs and other values such as time periods.
Although that's not a smali feature what do you think about implementing it in this extension? Say a shortcut to toggle between HEX and DEC values or right-click and convert radix.

For a resource ID in hexadecimal format like this:

const v1, 0x7f050001

when hover on 0x7f050001 an onHover tip could be shown, after searching in R$*.smali files, like this:

R$layout.main

or simply:

layout:main

Advantage: It will save the time of doing search and find the id each time these values are encountered.

Hi. I've been uploading Smalise to open-vsx.org for people who don't use official VS Code builds, but it has been removed due to missing license. Could you please add a proper LICENSE file and update package.json?