Coder Social home page Coder Social logo

faraday-http's People

Contributors

dependabot[bot] avatar hgeorgilas avatar imactia avatar jrochkind avatar karissekjw avatar m-nakamura145 avatar nuckchorris avatar olleolleolle avatar technoweenie avatar tylerkahn avatar utkarsh2102 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

faraday-http's Issues

Release a gem checklist Issue

This Issue is a sign-post issue ๐Ÿšฉ about things we need to have done before releasing this as a gem.

TODO

  • Use GitHub Actions #14
  • GitHub Actions to publish gem
  • Drop CircleCI
  • .github/*.md content from Faraday
    • CONTRIBUTING.md
    • ISSUE_TEMPLATE.md
    • PULL_REQUEST_TEMPLATE.md
  • Complete the README
  • Complete the gemspec
  • Release on RubyGems

Compatibility issues with Ruby greater or equal to 2.7

I tried using this gem with Ruby 2.7.1 and I got the following error

#<FrozenError: can't modify frozen String: "">

It seems the issue is the http.rb version dependency you declare in your gemspec file.

spec.add_dependency 'http', '~> 3.0'

This issue seems to be fixed on the 4.2.1 version of http.rb

Maybe bumping the dependency version would be enough.

Full Stack trace

".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/http-3.3.0/lib/http/response/body.rb:52:in `force_encoding'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/http-3.3.0/lib/http/response/body.rb:52:in `to_s'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/bundler/gems/faraday-http-80c9bedffbb2/lib/faraday/adapter/http.rb:29:in `perform_request'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/bundler/gems/faraday-http-80c9bedffbb2/lib/faraday/adapter/http.rb:16:in `call'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/faraday_middleware-1.0.0/lib/faraday_middleware/response_middleware.rb:36:in `call'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/faraday_middleware-1.0.0/lib/faraday_middleware/response/follow_redirects.rb:79:in `perform_with_redirection'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/faraday_middleware-1.0.0/lib/faraday_middleware/response/follow_redirects.rb:67:in `call'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/faraday-1.0.1/lib/faraday/request/retry.rb:148:in `call'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/faraday-1.0.1/lib/faraday/request/url_encoded.rb:25:in `call'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/faraday-1.0.1/lib/faraday/rack_builder.rb:153:in `build_response'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/faraday-1.0.1/lib/faraday/connection.rb:492:in `run_request'",
 ".rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/faraday-1.0.1/lib/faraday/connection.rb:198:in `get'",

Thanks

EDIT:
Cloned the repo locally, updated gemspec dependency of http.rb to
spec.add_dependency 'http', '~> 4' specs seems to be passing.
Have not tested further than that though.

Gem not published

The README indicates to install the gem named faraday-http, but this gem does not exist in the the RubyGems repos. Is this an oversight, or is the gem not ready to be published yet?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.