lorenzo0111 / infoheads

Repository for InfoHeads

👋 ・ Welcome

infoheads's Issues

Creation removal bug

When creating an info head, it can cause replacement of existing heads.

Cause:
When deleting a head it can cause the field private int keys to become out of sync.

Fix:

• Change creation variable to not rely on private int keys
• Use java UUID creation

Console commands do not work

Initially using PAPI OI tried to have the console use economy to give a player a specified amount of money and it wasn't working, so I tried using luckperms papi and that was not working either.

After a lot of trial and error, research and contacting support on the discord I realized the plugin itself was not working. I tried using the console command to give a player an item, put a player in creative and so on and nothing is working.

New update changed all saved worlds to "world"

After updating to the newest version, all "world" values in datastore.json were changed to "world". This caused all of my infoheads to be wiped until manually fixing the json file.

1.17 Update

This issue tracks plugin updates for 1.17 compatibility.

Todo:

• Fix gui
• Fix heads
• Test storage
• Test everything
• Fix head give

HeadDatabaseAPI being included in jar

HeadDatabaseAPI is included in the jar file of InfoHeads, which results in other plugins using HeadDatabaseAPI not working correctly. I added <scope>provided</scope> to the HeadDatabaseAPI dependency fixes this issue.

https://github.com/harry0198/InfoHeads-mvn/blob/9d153b1bec0f9d463226a3bed7f3849416e9bcf7/pom.xml#L66-L70

Move saved heads/blocks to their own file

I think it would be beneficial, if all heads/blocks would be saved in their own file (i.e. saves.yml) because this would be useful if you f.e. want to reset all saved blocks and don't want to recreate the config again (in case you use own heads.)

Suggestion: /infoheads edit

The idea would be a new subcommand: /infoheads edit [msg|cmd|block]

The command would allow you to edit the current settings of a block/head including the block/head itself.

Examples

/infoheads edit text
/infoheads edit cmd

Allows you to update the Message(s) or command(s) you set for the plugin.
To update it could be done like this:

• Run /infoheads edit msg|cmd
• Provide the new message(s)/Command(s)
• Left/Rightclick the block/head to change values from

/infoheads edit block

Updates the block/head you use for the command(s) and/or message(s).
To update:

• Run /infoheads edit block
• Destroy the old block and place the new one (Also perhaps on a new location to move)

Startup error

Updating to 2.0 gave me the following error on startup:

[03:25:37 INFO]: [InfoHeads] Enabling InfoHeads v2.0
[03:25:37 ERROR]: Error occurred while enabling InfoHeads v2.0 (Is it up to date?)
java.lang.NullPointerException: null
        at me.harry0198.infoheads.datastore.DataStore.addToConfig(DataStore.java:71) ~[?:?]
        at me.harry0198.infoheads.datastore.DataStore.addInfoHead(DataStore.java:46) ~[?:?]
        at me.harry0198.infoheads.InfoHeads.lambda$updateConfig$2(InfoHeads.java:152) ~[?:?]
        at java.util.ArrayList.forEach(ArrayList.java:1540) ~[?:?]
        at me.harry0198.infoheads.InfoHeads.updateConfig(InfoHeads.java:152) ~[?:?]
        at me.harry0198.infoheads.InfoHeads.load(InfoHeads.java:99) ~[?:?]
        at me.harry0198.infoheads.InfoHeads.onEnable(InfoHeads.java:75) ~[?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[patched_1.15.2.jar:git-Paper-146]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:337) ~[patched_1.15.2.jar:git-Paper-146]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:483) ~[patched_1.15.2.jar:git-Paper-146]
        at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugin(CraftServer.java:470) ~[patched_1.15.2.jar:git-Paper-146]
        at org.bukkit.craftbukkit.v1_15_R1.CraftServer.enablePlugins(CraftServer.java:384) ~[patched_1.15.2.jar:git-Paper-146]
        at net.minecraft.server.v1_15_R1.MinecraftServer.a(MinecraftServer.java) ~[patched_1.15.2.jar:git-Paper-146]
        at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:298) ~[patched_1.15.2.jar:git-Paper-146]
        at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:885) ~[patched_1.15.2.jar:git-Paper-146]
        at java.lang.Thread.run(Thread.java:834) [?:?]

Multiple bugs and issues

I discovered a small bug

Issue

When typing /infoheads reload I get /infoheads as a response right after the confirm message of the reload indicating that there is a missing return true or it just returns false.

Other small issues

Why is the plugin called InfoHeads when it can be used with any block?
And could you perhaps add that removing the head/block removes the setting from the config?

Move to maven repository for HeadDatabase

There seems to be an API available under mvnrepository.com to hook into and use HeadDatabase:
https://mvnrepository.com/artifact/com.github.shynixn.headdatabase/hdb-api