longshotlabs / meteor-plans Goto Github PK

Hey Aldeed

Thanks for sharing the package, I was wondering if you ever needed to introduce limits based on plan for example free plan can add 5 rss feeds while pro plan has limit of 15 rss feeds.

If you did how did you organise it? Extend the plan object with extra function checks? I'm having manual checks at the methods for now. Love to get some ideas maybe there is a package for it? Couldn't find any.

Thank you

There is an issue in the order of things done in this method

You must first update endDate, and then setAppPlansObject like so

// Update endDate to be null
  Utility.updateAppPlansObject(options, planName, {
    $unset: {
      'appPlans.list.$.endDate': '',
    },
  });

  Utility.setAppPlansObject(options, modifier);

  return true;

Otherwise, the $addToSet modifier does not work and it adds duplicate plans with exact same parameters in the appPlans.list object

https://github.com/aldeed/meteor-plans/blob/a6b2919600ca65317bdef021ae23350caa1bce60/server/utility.js#L86