lolipain / saas-vk-ticket-support Goto Github PK

The following file(s): GCPanel

Contains a lot of duplicated code fragments releated to adaptive rendering component <Groups />

https://github.com/P2LOVE/saas-vk-ticket-support/blob/ac8b53434ebe59c588ffb24302d32af404280699/client/src/Core/GCPanel/index.jsx#L72-L108

If required component-wrappers moved to a part of another adaptive components that should reduce quanity of same code parts

Before:

<Wrapper>
<Adaptive />
</Wrapper>
:
<Wrapper>
<Adaptive 2 />
</Wrapper>

After:

<Adaptive Wrapper />

Due to Stepper keys function Decrease must be callable only when some group is selected.
https://github.com/P2LOVE/saas-vk-ticket-support/blob/ac8b53434ebe59c588ffb24302d32af404280699/client/src/components/Stepper/index.jsx#L13-L20
https://github.com/P2LOVE/saas-vk-ticket-support/blob/ac8b53434ebe59c588ffb24302d32af404280699/client/src/Core/GCPanel/index.jsx#L96
Solution will be passing isMinimal prop till selected state equals default state additionally to current isMinimal behaviour when empty Groups component rendereing or rework it generally
https://github.com/P2LOVE/saas-vk-ticket-support/blob/ac8b53434ebe59c588ffb24302d32af404280699/client/src/Core/GCPanel/index.jsx#L72-L108

Review propTypes, especially DefaultProps aimed to remove ridiculous usage of default prop to .isRequired on type itself.

Some components maybe have an incorrect declaration of DefaultProps due to component will always have passed props on it

Trello linked issue

Card name: Ticket content overflow

Card link:

Ticket content overflow

Description:

Multiline text doesnt strip right. Max-height and max-width works only for rude stripping when it's overflowing.

https://github.com/P2LOVE/saas-vk-ticket-support/blob/ca72c06b85bc577b65a45109da58c55aaea11691/client/src/components/Ticket/Styles.js#L42-L55