lobsterbandit / use-countdown-timer Goto Github PK

Here is my component's code:

const Component = ({onSend}) => {
  const { countdown, start, reset, isRunning } = useCountdownTimer({
    timer: 1000 * 30,
  });

  const handleSubmit = useCallback(
    (values) => {
      onSend(values.phone);
      reset();
      start();
    },
    [start, reset, onSend];
  );
  
  return (
    <Button onClick={handleSubmit} disabled={isRunning}>Submit {countdown / 1000}</Button>
  );
}

and here is my test:

expect(submitButton).toBeDisabled();

act(() => {
  jest.advanceTimersByTime(31000);
});

expect(submitButton).toBeEnabled();

I found out that timer doesn't stop in this case, it shows 0 seconds, then -1 second, -2 seconds and so on...

Am I doing something wrong?

Pause method should halt the current timer until start() or reset() is called.
Countdown return value should remain the same until

• start() - Resume countdown timer. Countdown will change on next interval tick.

• reset() - Clear countdown timer, resetting to initial timer value and running any onReset callbacks.

when i pause actually what it happens it make isRunning and canStart to false , but i don't see clear interval for this senario
i think my solution can resolve this issue but i think i need to move interval ids in top level so i can access it on next render use Effect.

Add a github actions workflow to install deps/build/test the package and example.

Needs more tests

When using CRA 5, which uses Webpack 5, I'm getting the source-map error:
Failed to parse source map from '/node_modules/use-countdown-timer/src/index.ts

Please generate source maps as a part of the build output. Thanks.

Hey there, and thanks for the neat hook.

In my use case, I'm displaying a decreasing circular progress bar, based on the countdown. Currently when the countdown expires, the countdown value resets to initial, and causes my progress bar to rewind. I'd like to be able to stay at 0 value and only reset to initial when I actually call reset.

I would argue that this behavior should be the default one... what do you think?

i cannot reset() then start() again because when i want to start countdown is 0 and doesnt trigger the start

Apply autostart preference when timer is reset rather than only setting the initial state value.

Provide separate parameter startInitial or something to only set the initial state value.