lo48576 / fbxcel-legacy

Excellent FBX loader (legacy version, <0.0.3)

fbxcel

fbxcel is an FBX parser and loader for Rust programming language.

Versions

Versions before 0.1.0 are unstable and API compatibility will be broken.

License

Licensed under either of

• Apache License, Version 2.0, (LICENSE-APACHE.txt or https://www.apache.org/licenses/LICENSE-2.0 )
• MIT license (LICENSE-MIT.txt or https://opensource.org/licenses/MIT )

at your option.

Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any additional terms or conditions.

fbxcel-legacy's Issues

`SpecialAttribute::reader()` will return reader with invalid offset after second call

https://github.com/l1048576/fbxcel/blob/d2351524d64b2687972d2464d5a7d3c37f9e825d/src/parser/binary/event/attribute/special.rs#L37-L42

    /// Returns reader of the raw attribute value.
    pub fn reader(&mut self) -> LimitedSeekReader<&mut R> {
        let begin = self.parser.source.position();
        let end = begin + self.rest_len();
        LimitedSeekReader::new(self.parser.source.by_ref(), begin, begin, end)
}

If the reader has been read, self.parser.source.position() can be non-begin position, so the next reader() call will use wrong range to create LimitedSeekReader.

This should be look like:

    /// Returns reader of the raw attribute value.
    pub fn reader(&mut self) -> LimitedSeekReader<&mut R> {
        let current = self.parser.source.position();
        let begin = self.end_offset - self.total_len();
        LimitedSeekReader::new(self.parser.source.by_ref(), current, begin, self.end_offset)
}

Impl `BufRead` for `BasicSource, `SeekableSource` and `LimitedSeekReader`

If R: BufRead, then also BasicSource, SeekableSource and LimitedSeekReader should impl BufRead.

This enables us to load images without BufReader.
(::image::load() requires R: BufRead + Seek, therefore current fbxcel requires BufReader to load image from the LimitedSeekReader.)