lneugebauer / nextcloud-cookbook Goto Github PK

Describe the bug

Instal the App, connect via nextcloud files app.
No recipes shown and an error message in the category tab.

Use JsonReader.setLenient(true) to accept malformed Json on line 1 column 1 path $

To Reproduce
Steps to reproduce the behavior:

1. Go to App
2. See error

Expected behavior

Should connect to cookbook Plugin that's working inside thr nextcloud website.

Screenshots

Smartphone:

• Device: Asus Zenfone 9
• OS: Android 13
• Version 0.14.6

Additional context

If api gets updated show a disclaimer to warn the user that the app might not work properly.

The website should contain information about the app, documentation and privacy statement.

Describe the bug
I can't connect to my Nextcloud server that uses HTTP instead of HTTPS. This server runs on my internal network over a VPN, so HTTPS provides no real benefit and there's no reason for me to go to the trouble of generating a certificate for it and distributing that certificate to all of the devices that connect to it.

To Reproduce
Steps to reproduce the behavior:

1. Set up a Nextcloud server that uses HTTP
2. Input the URL of the server in Nextcloud Cookbook
3. See error: "Invalid protocol; URL must start with https://"

Expected behavior
Nextcloud Cookbook should allow connecting to servers that use HTTP.

Smartphone:

• Device: Pixel 7
• OS: GrapheneOS 2023103100 / Android 14
• Nextcloud: 25.0.2
• Cookbook: 0.14.4

I have a local nextcloud instance that use a self-signed certificate. If i try to login to my nextcloud in the app i got an certificate error. I think my self-signed certificate does the issue. It is possible to ignor the self-signed certificate during the login?

java.util.NoSuchElementException

kotlin.collections.CollectionsKt___CollectionsKt.random

java.util.NoSuchElementException: 
  at kotlin.collections.CollectionsKt___CollectionsKt.random (CollectionsKt___Collections.kt)
  at de.lukasneugebauer.nextcloudcookbook.feature_recipe.domain.use_case.GetHomeScreenDataUseCase.invoke (GetHomeScreenDataUseCase.java)
  at de.lukasneugebauer.nextcloudcookbook.feature_recipe.domain.use_case.GetHomeScreenDataUseCase$invoke$1.invokeSuspend (GetHomeScreenDataUseCase.java:11)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (BaseContinuationImpl.java)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.java:86)
  at android.os.Handler.handleCallback (Handler.java:938)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:226)
  at android.os.Looper.loop (Looper.java:313)
  at android.app.ActivityThread.main (ActivityThread.java:8663)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:567)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1135)

Is your feature request related to a problem? Please describe.
Some users don't speak English at all, so your application is useless for them.

Describe the solution you'd like
I'd like to see support for community translations in your application, so more users could use it and completely understand it.

Use the android library to authenticate through the Nextcloud files app.

The prefered way of authenticating should be through the Nextcloud files app. As an alternative the user should still be able to authenticate with username and app password.

Is your feature request related to a problem? Please describe.
Most recipes specify an exact amount of ingredients for a certain number of people. Since this rarely matches the amount of servings I need, it's kind of frustrating and also failure prune to do this in my head.

Describe the solution you'd like
As in the nextcloud webapp, it would be very helpful if we had the option to change the portions and automatically recalculate the amount of ingredients needed with a control like this:

Maybe it would make sense to put it just before the text "Ingredients for x servings":

Describe alternatives you've considered
Maybe its also an option to use a slider to change the amount of servings

java.lang.IllegalArgumentException

de.lukasneugebauer.nextcloudcookbook.di.ApiProvider.initRetrofitApi

java.lang.IllegalArgumentException: 
  at retrofit2.Retrofit$Builder.baseUrl (Retrofit.java)
  at retrofit2.Retrofit$Builder.baseUrl (Retrofit.java)
  at de.lukasneugebauer.nextcloudcookbook.di.ApiProvider.initRetrofitApi (ApiProvider.java)
  at de.lukasneugebauer.nextcloudcookbook.di.ApiProvider.access$initRetrofitApi (ApiProvider.java)
  at de.lukasneugebauer.nextcloudcookbook.di.ApiProvider$initApi$1.invokeSuspend (ApiProvider.java)
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (BaseContinuationImpl.java)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.java:86)
  at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely (CoroutineScheduler.java)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask (CoroutineScheduler.java)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker (CoroutineScheduler.java)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run (CoroutineScheduler.java)

Use compose destinations library to simply navigation and reduce boilerplate code

Describe the bug

There is an issue in Weblate that causes lint errors on Android in certain languages.

Expected behavior

The MissingQuantity check should be re-ebabled once the Weblate issue is solved.

Additional context

WeblateOrg/weblate#7520

Add a searchbar at the topbar.

UX proposal:

Add Button open up dropdown to the top and select the search button or add button.

Screenshot follows.

Describe the bug
When I try to install this app via APK file downloaded from GitHub release, Play protect blocks it (see attached screenshot). There is a way, how to workaround this by showing more details (screenshot contains this screen) and tapping on "Install anyway".

To Reproduce
Steps to reproduce the behavior:

1. Download APK file from GitHub release
2. Try to install app via downloaded APK file
3. See alert from Play protect (as displayed on screenshot below)

Expected behavior
App is installed without blocking and alert from Play protect.

Screenshots

Smartphone:

• Device: Samsung Galaxy S22
• OS: Android 13
• Version 0.12.0+26

Add api call to get all recipes and recipe details. For now authentication should be done by username and app password.

It would be very useful if you could filter the recipes by tag. In my opinion, the category alone is not enough if you have a large collection.

Is your feature request related to a problem? Please describe.
When your Nextcloud server is down, you can't access your recipes any more.

Describe the solution you'd like
The app should save an offline copy of the recipes, and sync them when the server is back online again.

https://hosted.weblate.org/translate/nextcloud-cookbook/app/cs/?checksum=be7821cc73089bad

Hi, I need to set different version of plural form of "hours" (hodiny/hodin) and "minutes" (minuty/minut) to Weblate but it's configured just for a single form. Could you change it, please?

Add ktlint to improve code quality.

Is your feature request related to a problem? Please describe.
I can not currently share creation and maintenance of recipes with my family on our NextCloud.

Describe the solution you'd like
Being able to use the GroupFolder or otherwise to share our recipe inventory would be amazing.

Describe alternatives you've considered
Currently, I input everything and my wife borrows my phone to use the app.

Additional context
As it stands, phenomenal for regular individual usage. Just a bit clunky for family usage.

Add compat library for native splash screen and completely remove the custom one.

Describe the bug
When I edit the "Image URL" field in the recipe edit form and save it, the image doesn't change (even if I clear the "Image URL" field).

To Reproduce
Steps to reproduce the behavior:

1. Add recipe with the specified valid "Image URL" (of image 1)
2. See image 1 in recipe detail
3. Open edit recipe form
4. Change (or clear) "Image URL" (to URL of valid image 2)
5. See old image 1 in recipe detail

Expected behavior
There is image 2 (or no image, resp.) in recipe detail.

Smartphone:

• Device: Samsung Galaxy S22
• OS: Android 13
• Version: v0.12.1+27

Hi! While browsing the nextcloud cookbook developer documentation, i found out that you have created a new android app. So far it looks good, but glancing from the featureset, it looks like we are trying to solve the same issue. (I am not the maintainer of the micmun-cookbook-app, just helping out regulary)

Since we are trying to solve the same issue, maybe it would be possible to join forces in some way? (As an example, i am currently hard at work implementing editing). I am not really close in touch with the other maintainer, but we could try to make it more active!

Sorry if i am intruding unwelcome. Otherwise, thanks!

Is your feature request related to a problem? Please describe.
Quantity is currently the same string as the ingredient. Does it go first, last? How do we separate it? It can not scale with servings.

Describe the solution you'd like
Being able to input the numeric quantity and unit alongside the ingredient string.

Describe alternatives you've considered
Using as-is, but I am already seeing I am not self-consistent, let alone with other family users inputting stuff.

Additional context
Will likely be necessary for serving size scaling.

Describe the bug

I try to connect the cookbook app (f-droid) to my NC instance where i have few recipes in my cookbook. I have https enabled on my instance. When trying to connect the app, it doesn't log in and instead i have a red error message saying certificate error.

To Reproduce
Steps to reproduce the behavior:

1. Enable https on your instance
2. Try to connect through the cookbook app.
3. See error

Expected behavior

When trying to log in, the app should ask to validate the certificate and then login. It works like that for the nextcloud app, the money buster app, the Deck app, ...

• Device: Pixel 7
• OS: Android 13
• OS instance : Debian 11
• NC : 27.1.2
• Cookbook android : 0.14.1
• Cookbook on NC instance : 0.10.2

Additional context

NC instance is self-hosted and not open to the internet.

List all recipes and show detail view on click.

Is your feature request related to a problem? Please describe.
Many recipes have nutrition information available for a given serving size.

Describe the solution you'd like
It would be amazing if we could input things like macro and micro nutrient info alongside calories.

Describe alternatives you've considered
Using description sort of works, but it is static and cant be filtered or grouped on.

Additional context
Having this scale along with serving size would be phenomenal.

Add a preparation wizard. Swipe to fullfill or click on arrows to get to the next step.

WIP:

Describe the bug
When I open special "virtual" category (with 3 items in my case) for uncategorised recipes, it shows no recipes and a message "No recipes found".

To Reproduce
Steps to reproduce the behavior:

1. Open Cookbook app
2. Have at least 1 recipe without category
3. Go to tab "Categories"
4. Tap on "Uncategorised recipes"
5. See "No recipes found", although we have at least 1 recipe without category

Expected behavior
Recipes without category are displayed there.

Screenshots

Smartphone:

• Device: Samsung Galaxy S22
• OS: Android 13
• Version: v0.12.1+27

Text color of input fields is black instead of white if dark mode of device is enabled.

Docs: https://f-droid.org/en/docs/Setup_an_F-Droid_App_Repo/

Describe the bug
I added some recipes without category and "Categories" screen doesn't work properly.

To Reproduce
Steps to reproduce the behavior:

1. Open app
2. Log in with new account with no recipes
3. Add one or more recipes without category
4. Go to screen "Categories"
5. See "*" category (as shown in screenshot below)

Expected behavior
As no categories are defined, show message "No categories found".

Screenshots

Smartphone:

• Device: Samsung Galaxy S22
• OS: Android 13
• Version: 0.8.0 (14)

I have imported this recipe URL using this app, and it shows up fine in the Nextcloud Cookbook web UI, but fails to open in the Android app. The recipe thumbnail is shown correctly, but when tapped, the text Exception: type '_OneByteString' is not a subtype of type 'int' is shown. The edit button at the top right does nothing.

Describe the bug

I use your Android-App for a look into my nextcloud recipes. If I choose the middle bottom button for a list of my categories and I click on a category with more than one recipies inside, the app crashes.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

I would have shown a list of my recipes related to the choosen category.

Screenshots

Smartphone:

• Device: [e.g. Pixel 7]
• OS: [e.g. Android 13]
• Version [e.g. 22]
  Device: Redmi Note 11S
  OS: MIUI 14.0.3

Additional context

I have a category with only one related recipe. If I choose this category the related recipe will be shown. No app crash.

I would love to see a search function and the ability to filter for keywords. E.g. if i want to eat something with potatoes in can filter for this keyword and see all recipes with the keyword potatoe.

Is your feature request related to a problem? Please describe.
When I want to add image to the recipe, it is quiet problematic. I think this problem has 2 branches, so I divide my text into these.

Web (or external) images. When I have an image outside my Nextcloud and want it to add to the recipe, I need to get its URL (complicated for average user), when it's publicly available (web image) or upload it somewhere and copy URL (other images), which is too complicated and time consuming for most users, I think.

Nextcloud images. When the image is located on my Nextcloud, I just need to enter path from Nextcloud root. It is better but manual entering isn't very user friendly. Web version of Nextcloud Cookbook has a image selector for this.

Describe the solution you'd like
I'd like to see some option for uploading an external image using this app (just some simple file input, I think there are some many libraries for this purpose), copying its path and inserting it into the input (or better hiding these things and just displaying a preview of the uploaded image). This picker should have a way to select image from Nextcloud files.

Is your feature request related to a problem? Please describe.
When you open "fresh" form for adding recipes, time input fields are empty. When you tap into them, zeros are filled. After saving and reopening recipe in edit form zeros are still in present.

Describe the solution you'd like
I'd appreciate if time inputs with zeros will be cleared after saving. It could be more synoptical.

It would be a nice feature, if users could share their recipies with users by sharing an external link. Ideally that would be an external link (analogue to external links when sharing files) allowing to share links also with people that are not users on the nextcloud instance.

Describe the bug
Crash after the first logon.

To Reproduce
Steps to reproduce the behavior:

1. Start app
2. Logon to NC
3. Crash
4. Restart app
5. Crash
6. ...

Smartphone:

• Device: Pixel 6
• OS: Android 13

Server:

• Nextcloud: 26.0.3
• Cookbook: 0.10.2

Your Readme shows a badge stating one could get the app from Github releases – but there aren't any APKs attached to the releases. Did you just forget to attach them, or is it some Github workflow failing?

Add the possibility to add the ingredients of a recipe to some shopping list.

As a first version this could be a local shopping list. E.g. stored in room.

For later updates ingredients could be stored in multiple other apps.

ref: 026799e

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/4868497953#L358

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/994e31f1cf8b7a7d9c541928e7050f5a3f918238

Open source licences should be viewable through app settings.