Comments (4)
You're right... The display enum used to be calculated based on the logical dimensions of the screen (points). This created a problem with the new iPad Pro devices in two sizes because it made their screens indistinguishable. Between iPhone 5/5S/5C, it was still somewhat acceptable, but having an iPad Pro with a 9.7 inch and a 12.9 inch display returning the same value was definitely wrong.
But you're right that this is a breaking change. At least on the simulator--on real devices it's not. I'll restore the previous functionality as a patch release on 4.x, and make a major bump to 5.0.0 with the new functionality.
from gbdeviceinfo.
I just realised that this was published as a major bump, from 3.8.0
to 4.0.0
.
from gbdeviceinfo.
Is this scheduled for release any time soon @lmirosevic?
from gbdeviceinfo.
@philipengberg No need for a release. 3.8.0
returns screen info on the Simulator, but going forward this can't be done reliably (see comment above). And 4.0.0
has the new robust behaviour--but device only.
from gbdeviceinfo.
Related Issues (20)
- Latest release does not include HEAD of master HOT 1
- iPhone11 ProοΌ HOT 2
- Undefined symbol: _OBJC_CLASS_$_GBDeviceInfo missing required architecture armv7
- [GBDeviceInfo deviceInfo].displayInfo.pixelsPerInch
- iPhone SE (2020) ? HOT 1
- v6.5.0 - fatal error: 'GBDeviceInfo/GBDeviceInfo.h' file not found HOT 4
- Support Swift Package Manager HOT 2
- Support iPhone13 HOT 1
- Missed iPad Pro 5gen
- Missing 8.3-inch display size for new iPad mini
- Missing 3rd generation iPhone SE HOT 1
- Heads: DeviceFamily probably won't be reliable on some newer Macs HOT 2
- Availability of 6.8.0 via cocoapods? HOT 1
- Is there anything else besides these?
- Crashing on iOS 12 (iPhone 6) HOT 1
- Can you please add iPhone 15 and other new devices? HOT 3
- Please add latest iPhones to the list. HOT 2
- Releasing a new version HOT 2
- Request for 2024 iPad Support HOT 1
- Unknown Devices For Greater then iPhone X HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gbdeviceinfo.