Hard to deal with shared library about units

[phlptp]

Thanks for the suggestions. None of our use cases ever use the shared library or install it, so it really hasn't gotten much attention.
We pretty much static link it as a submodule or just include the code directly. C++ shared libraries are always a bit dicey in my opinion. But regardless seems like it could be done better.

Would you propose disabling the ability to make both the static and shared libraries at the same time? If not how would you distinguish between them?

[kerim371]

@phlptp thank you for a quick reply,

Would you propose disabling the ability to make both the static and shared libraries at the same time? If not how would you distinguish between them?

In my experience there were no necessarity to create both static and shared libs at the same time. But I have seen such option few times even in quite big libraries (as I remember VTK provides this but I may be mistaken)

I think that units can be built static by default (i.e. when UNITS_BUILD_SHARED_LIBRARY=OFF) and only if UNITS_BUILD_SHARED_LIBRARY=ON then units should be built in shared mode.

BUT regarding how UNITS_HEADER_ONLY var is working the above proposition can be modified in the following way:

if I understand correct UNITS_HEADER_ONLY makes units to build and install headers only (something like copy include directories to install folder). In this case I think if UNITS_BUILD_SHARED_LIBRARY=ON then there is no need to process UNITS_HEADER_ONLY var because include folder will be copied anyway.
If UNITS_HEADER_ONLY=ON and UNITS_BUILD_SHARED_LIBRARY=OFF then we don't want to build neither static nor shared library and we install only include folder.
If UNITS_HEADER_ONLY=OFF and UNITS_BUILD_SHARED_LIBRARY=OFF then we build static library because there is nothinh else user can expect from building.

Also I expect that if a library provides all the three header only/shared/static mode then I don't want to distinguish my cmake code and C++ code with thoughts like: "What if my user wants to build my library and link to shared units library then I need... Or if he wants to link to static units...". This is super annoying :)