Comments (12)
Thanks for the insight. Here is a little update:
We have uploaded a conan recipe to our in-house server: https://artifactoryconan.esss.dk/artifactory/webapp/#/artifacts/browse/tree/General/scipp/scipp/LLNL-Units/0.5.0/stable
We chose this solution because it simplifies testing. But we might revisit it in the future.
from units.
All our current use cases use the library as a git submodule or just use the code directly. Some of the platforms we need to support don't have Conan available easily so support for it hasn't been a priority.
I have not looked much into what is involved in supporting it. I have no issue with it being added to Conan.
from units.
Eventually it might be nice having it added to conan-center-index, though they currently require signing a CLA to submit packages.
from units.
Ah yes, I am not allowed to sign CLA's for the time being which means though we would be happy to have it, we would need an outside contributor to make any additions to conan-center
from units.
Hi,
I was also considering adding units to vcpkg, but ran into a naming issue, in vcpkg units already points to https://github.com/nholthaus/units hence using units will not work since that name has to be unique.
I see that jl-wynen used llnl-units above, which would work also in vcpkg. The only problem then is the cmake package (find_package(units)), using units there is probably fine, since a user will probably only have one units library, but it might lead to collisions? Would you consider renaming also the cmake package to something like llnl-units?
from units.
In our recipe we have named the cmake package LLNL-Units, see our conanfile and our cmake-conan config and our
target_link_libraries(... LLNL-Units::LLNL-Units).
from units.
@SimonHeybrock so you manually patched the units target to be named LLNL-Units instead? or does Conan generate its own cmake targets? Vcpkg generally uses the same targets that is exported by the library it self. And generally vcpkg ports tries hard to avoid changing any names from the source, to make it easier just to "drop in" a vcpkg package.
from units.
@SimonHeybrock so you manually patched the units target to be named LLNL-Units instead? or does Conan generate its own cmake targets?
We are not patching anything, just using the regular sources from git, i.e., probably Conan makes its own targets?
from units.
I added a cmake variable to allow a rename of the project as an experiment. I don't really want to rename the project by default, but I do see the potential for conflict with other "units" libraries. #310 Not sure if that will work for your needs or not?
from units.
@phlptp do you have a preferred alternative name? LLNL-Units? or all lowercase llnl-units?
from units.
release has been made with the CMAKE variable to customize the project name. -DUNITS_CMAKE_PROJECT_NAME=LLNL-UNITS
should do what you want it to do. The default is left as UNITS
.
from units.
@phlptp fyi microsoft/vcpkg#37417
from units.
Related Issues (20)
- Convert to inverse unit incorrect HOT 1
- Issues with parsing single-letter prefixes such as for `atto` HOT 7
- CleanUnitString breaks on 0.2 and 0.3 HOT 1
- Strange choice of units in to_string HOT 6
- Your units conversion service seems to be down... HOT 11
- "kg m" is parsed as "kg" HOT 1
- Surprising parse results with `.` and `-` HOT 4
- Question about to_string() function HOT 8
- Format arbitrary unit nicely HOT 4
- Degrees celsius get converted to Kelvin in operations HOT 6
- Function to remove a single user defined unit HOT 2
- Try to start a PR for adding support for KPa, MPa, GPa but permission denied HOT 3
- Using to_string for scalars causes crashes HOT 2
- Use of uninitialised memory in unit maps HOT 7
- "Stress testing" units' string parsing HOT 8
- Favoring SI base units in string formatting? HOT 3
- to_string strange output HOT 4
- expression did not evaluate to a constant HOT 4
- Unary negation of measurements HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from units.