lkishalmi / netbeans Goto Github PK

There is a Gradle part of the NetBeans-Gradle integration which is a Gradle project residing inside the gradle module called by extending the module build scripts.
Is there a better way to do that?

Wrong hash signatures for SLF4J dependencies

Steps to Reproduce

1. Clean the local maven repository of the slf4j
2. Perform a maven dependency get: mvn dependency:get -Dartifact=org.slf4j:slf4j-api:1.7.25
3. Build the branch

Expected Result
Build completes successfully

Actual Result
Build fails as the hash's persisted in the branch do not match the hash's computed against the fresh slf4j files.

I locally had to use:
DA76CA59F6A57EE3102F8F9BD9CEE742973EFA8A org.slf4j:slf4j-api:1.7.25 BCCDA40EBC8067491B32A88F49615A747D20082D org.slf4j:slf4j-jdk14:1.7.25

Impact
Without fixing this issue a PR to Apache NetBeans will fail as Jenkins/Travis will compute the wrong hashes

Right now the external third party modules:

• Gradle Tooling API
• Log4j API and JDK backend
  are sitting in the release/modules/gradle folder We need to move them to the external libraries.

gradle.java module has an external dependency on jacoco.jar which should be moved to our external store.
The coverage support couls be separated from the Java module if required (like: maven.coverage).
Also jacoco library is under several license. Including Eclipse, BDS and Apache

When I do the following:

1. curl -s "https://get.sdkman.io" | bash
2. sdk install grails
3. grails create-app demo

...I now have a Grails project, which in other words means I'm using Groovy. This scenario is not supported by the (your) Gradle plugin, since your Gradle plugin only focuses on Java-based projects. And so even though I can open the 'demo' project created above, as a Gradle project with your Gradle plugin in Apache NetBeans 10, I can't run it because your plugin doesn't support Groovy and hence doesn't know how to run a Main method in a Groovy file.

Have you thought about this use case and do you have plans to provide this -- or what would it take to add this, would be happy to help provide this functionality, so that we can support Grails.

Normal $ ant build fails unless you have already have gradle-tooling-api-4.10.2.jar installed in your local maven repository.

Steps to Reproduce

1. Clean the local maven repository of the gradle api tooling files
2. Build the branch

Expected Result
Build completes successfully

Actual Result
Build fails with the following error:
BUILD FAILED /Users/john/codebase/incubator-netbeans/nbbuild/build.xml:125: Could not download 70A74F970B22AC1226F6A2983E38A77FA90E3BE9-gradle-tooling-api-4.10.2.jar from http://netbeans.osuosl.org/binaries/: java.io.IOException: Could not download 70A74F970B22AC1226F6A2983E38A77FA90E3BE9-gradle-tooling-api-4.10.2.jar to /Users/john/.hgexternalcache/70A74F970B22AC1226F6A2983E38A77FA90E3BE9-gradle-tooling-api-4.10.2.jar: java.io.IOException: Skipping download from http://central.maven.org/maven2/org/gradle/gradle-tooling-api/4.10.2/gradle-tooling-api-4.10.2.jar due to response code 404 at org.netbeans.nbbuild.extlibs.DownloadBinaries.doDownload(DownloadBinaries.java:249) at org.netbeans.nbbuild.extlibs.DownloadBinaries.fillInFile(DownloadBinaries.java:190) at org.netbeans.nbbuild.extlibs.DownloadBinaries.execute(DownloadBinaries.java:154) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) at org.apache.tools.ant.Task.perform(Task.java:350) at org.apache.tools.ant.Target.execute(Target.java:449) at org.apache.tools.ant.Target.performTasks(Target.java:470) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1388) at org.apache.tools.ant.Project.executeTarget(Project.java:1361) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.apache.tools.ant.Project.executeTargets(Project.java:1251) at org.apache.tools.ant.Main.runBuild(Main.java:834) at org.apache.tools.ant.Main.startAnt(Main.java:223) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101) Caused by: java.io.IOException: Skipping download from http://central.maven.org/maven2/org/gradle/gradle-tooling-api/4.10.2/gradle-tooling-api-4.10.2.jar due to response code 404 at org.netbeans.nbbuild.extlibs.DownloadBinaries.downloadFromServer(DownloadBinaries.java:275) at org.netbeans.nbbuild.extlibs.DownloadBinaries.mavenFile(DownloadBinaries.java:177) at org.netbeans.nbbuild.extlibs.DownloadBinaries.lambda$execute$0(DownloadBinaries.java:154) at org.netbeans.nbbuild.extlibs.DownloadBinaries.doDownload(DownloadBinaries.java:226) ... 18 more

Impact
Without fixing this issue a PR to Apache NetBeans will fail as Jenkins/Travis will be unable to local the correct jar.

Attempting to use ant -q -Dbinary.server=https://jcenter.bintray.com/ also failed so I ended up downloading the jar from https://repo.gradle.org/gradle/libs-releases-local/org/gradle/gradle-tooling-api/4.10.2/ locally to my maven repo